It would help a few cleaning up (especially #144538: User logout is vulnerable to CSRF and #370454: Simplify page caching) to have the session_id, session_name available. This will allow us to simplify session tests, and to compute security tokens on the testing side.

CommentFileSizeAuthor
#6 drupalGetToken_hash_salt_00.patch615 bytesxano
#6 drupalGetToken_hash_salt_00-d7.patch595 bytesxano
#2 477038-drupalwebtestcase-session-support.patch3.21 KBdamien tournoud
#1 477038-drupalwebtestcase-session-support.patch2.3 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 477038-drupalwebtestcase-session-support.patch2.3 KB
damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 477038-drupalwebtestcase-session-support.patch3.21 KB

And a second version, thanks to chx.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

This is good and although it does not have tests , there are many tests coming that will use this.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

This looks good. Committed. Looking forward to the follow-up patches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: Unassigned » xano
Status: Closed (fixed) » Needs review
StatusFileSize
new drupalGetToken_hash_salt_00-d7.patch595 bytes
new drupalGetToken_hash_salt_00.patch615 bytes

Tokens are unusable, because DrupalWebTestCase::drupalGetToken() does not use a hash salt, while drupal_get_token() does.

The patches make drupalGetToken() up to date with drupal_get_token().

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned
Status: Needs review » Closed (fixed)

Ah, of course. This is a 7.x issue. I moved the patches to #1555862: DrupalWebTestCase::drupalGetToken() does not add hash salt.