Currently, salesforce_api_password & salesforce_api_token are currently saved as plain text passwords in the variable table. Is it possible to hash those values?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | salesforce-477182-10.patch | 16.94 KB | kostajh |
| #5 | 477182-encryption-5.patch | 17.07 KB | 13rac1 |
| #4 | 477182-encryption-4.patch | 17.1 KB | 13rac1 |
| #3 | 477182-encryption.patch | 17.02 KB | aaronbauman |
Comments
Comment #1
rbora commentedActually, I was just about to request this hashing myself (preferably a strong/secure hash). I imagine this is a real quickie feature request, best done by JoshK/Aaron/Bevan.
However, if not, I could have a different "credential encryption module" (that I had produced for the Ubercart Authorize.net CIM module) re-purposed into an add-on for this module. This add-on module would be called "Salesforce API Encryption" or something. Having a whole separate little module for this feature might be overkill-- but if you decide you want this help, I will have it done asap.
Comment #2
Bevan commentedPatches welcome as well as integration with other modules providing this API
Comment #3
aaronbaumanIn this patch:
salesforce_api_encrypt,salesforce_api_decrypt, andsalesforce_api_encryption_availableto abstract AES dependency and make pluggable encryption easier in the future.Notes:
Comment #4
13rac1 commentedUpdated patch to current dev (2010-Jun-09) code and README.txt styling. Works as described.
Comment #5
13rac1 commentedFixed some trailing spaces and formatting.
Comment #6
aaronbaumanComment #7
EvanDonovan commentedSubscribing...maybe will test/re-roll in next few weeks.
Comment #8
kostajh commentedThe patch no longer applies cleanly to salesforce_api.admin.inc, so the variables aren't getting encrypted. I'll try to work on this soon.
In hook_requirements, line 175:
If we are requiring encryption to use the Salesforce module, then the wording should change to "Using encryption is required" (rather than just highly recommended).
Personally, I would prefer to change the severity to REQUIREMENT_WARNING, because I don't think this should be a requirement for using the module.
Comment #9
EvanDonovan commented@kostajh: Sounds good (in re: making it a warning).
Comment #10
kostajh commentedAttached patch applies cleanly against 6.x-2.x-dev, and changes the severity level to a warning (instead of error) if encryption is unavailable.
I tested and it works great.
Comment #11
aaronbaumanOK, this is in.
Thanks for contribs and testing.
related: another advantage of #990700: Support the new REST API would be that credentials wouldn't be stored on the server at all, only the REST auth token.