Download & Extend
Salesforce Suite » Issues

Encrypt API password and token

Posted by rj on May 30, 2009 at 7:33am
Project:Salesforce Suite
Version:6.x-2.x-dev
Component:salesforce_api
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Currently, salesforce_api_password & salesforce_api_token are currently saved as plain text passwords in the variable table. Is it possible to hash those values?

Login or register to post comments

Comments

#1

Posted by rbora on May 31, 2009 at 8:43am

Actually, I was just about to request this hashing myself (preferably a strong/secure hash). I imagine this is a real quickie feature request, best done by JoshK/Aaron/Bevan.

However, if not, I could have a different "credential encryption module" (that I had produced for the Ubercart Authorize.net CIM module) re-purposed into an add-on for this module. This add-on module would be called "Salesforce API Encryption" or something. Having a whole separate little module for this feature might be overkill-- but if you decide you want this help, I will have it done asap.

#2

Posted by Bevan on July 31, 2009 at 8:30am
Title:More secure salesforce_api_passowrd & salesforce_api_token» Encrypt API password and token
Status:active» needs work

Patches welcome as well as integration with other modules providing this API

#3

Posted by aaronbauman on May 19, 2010 at 1:54pm
Status:needs work» needs review

In this patch:

  • Implementation of optional but recommended encryption for SF credentials using AES Encryption module.
  • Security for credentials: fields on SF settings form are now password fields instead of textfield fields.
  • Credentials are never displayed to the user through the UI.
  • If the user leaves the credentials fields blank, existing credentials are not overwritten.
  • Added a checkbox to erase existing credentials.
  • Added runtime case to hook_requirements to throw a requirement error when encryption is not being used.
  • Added runtime case to hook_requirements to throw a requirement warning when database encryption is used instead of file encryption.
  • Added wrapper functions salesforce_api_encrypt, salesforce_api_decrypt, and salesforce_api_encryption_available to abstract AES dependency and make pluggable encryption easier in the future.
  • Updated README with notes about encryption and security.

Notes:

  • This will NOT enable encryption of existing credentials. If you install this patch, you'll have to also re-enter your credentials before they are encrypted.
  • The variable storage location has not changed - credentials are still stored in the variable table. salesforce_api_connect properly decrypts the variables, but any module accessing the variables directly will need to implement decryption as well.
AttachmentSize
477182-encryption.patch 17.02 KB

#4

Posted by eosrei on July 4, 2010 at 2:10am

Updated patch to current dev (2010-Jun-09) code and README.txt styling. Works as described.

AttachmentSize
477182-encryption-4.patch 17.1 KB

#5

Posted by eosrei on July 5, 2010 at 9:40pm

Fixed some trailing spaces and formatting.

AttachmentSize
477182-encryption-5.patch 17.07 KB

#6

Posted by aaronbauman on July 14, 2010 at 2:57pm
Component:Code» salesforce_api

#7

Posted by EvanDonovan on January 11, 2011 at 9:17pm

Subscribing...maybe will test/re-roll in next few weeks.

#8

Posted by kostajh on January 20, 2011 at 10:32pm

The patch no longer applies cleanly to salesforce_api.admin.inc, so the variables aren't getting encrypted. I'll try to work on this soon.

In hook_requirements, line 175:

<?php
      elseif (!salesforce_api_encryption_available(array('check_config' => FALSE))) {
        $description = t('Encryption is unavailable. Using encryption is <strong>highly recommended</strong> in order to better secure your data.');
        $severity = REQUIREMENT_ERROR;
      }
?>

If we are requiring encryption to use the Salesforce module, then the wording should change to "Using encryption is required" (rather than just highly recommended).

Personally, I would prefer to change the severity to REQUIREMENT_WARNING, because I don't think this should be a requirement for using the module.

#9

Posted by EvanDonovan on January 21, 2011 at 2:17pm

@kostajh: Sounds good (in re: making it a warning).

#10

Posted by kostajh on January 21, 2011 at 5:04pm

Attached patch applies cleanly against 6.x-2.x-dev, and changes the severity level to a warning (instead of error) if encryption is unavailable.

I tested and it works great.

AttachmentSize
salesforce-477182-10.patch 16.94 KB

#11

Posted by aaronbauman on February 2, 2011 at 9:07pm
Status:needs review» fixed

OK, this is in.
Thanks for contribs and testing.

related: another advantage of #990700: Support the new REST API would be that credentials wouldn't be stored on the server at all, only the REST auth token.

#12

Posted by System Message on February 16, 2011 at 9:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.