Hello!
I like this module and want to make it better. This patch replace old html tags (<i>, <b>..) with bbcode ([i], [b]..) and output it to modern (x)html (<em>, <strong>..). Also RSS feed have attached to each tribune node and each RSS item have a link (to node) and title (post_id). Some rss aggregators need it.

CommentFileSizeAuthor
#4 backend.patch1.65 KBGyt
#1 tribuneBB2.patch12.44 KBGyt
tribuneBB.patch6.22 KBGyt

Comments

Gyt’s picture

Title: BBCode + RSS Improvments » BBCode, User's timezones + RSS improvements
Component: User interface » Code
Category: feature » task
StatusFileSize
new12.44 KB

This is a new patch.
I be surprised, because "/settings/tribune/settings" isn't default settings.. And I do some more changes: add default pager and delete default totoz (you know, this service may be useful only for Frenchman).

Also I found one big problem: user's timezones. Using website's default time isn't right. All users seeing one time and get confused. But using different timezones will affect clock reference.. By the way, why do you use clock reference but not use simple anchors (e.g. <a id="post-456"></a>).

naheemsays’s picture

Instead of doing the actual filtering etc itself, how about using an inputformat (via check_markup())? could that not be better?

SeeSchloss’s picture

Okay, so:

I won't replace HTML tags with BBCode (I have a hatred for BBCode, actually). It wouldn't add anything and it would break compatibility with all the other tribunes (it was bad enough when Shoop switched to a wiki-like syntax). I'm now translating <i>, <b> and such to xhtml-compliant tags, though (I intended to do it long ago but I just forgot it).

Using a different timezone for every user would just make it unusable (unless you don't use clock references, and then... what's the point of using a tribune?)... now I've changed the timezones to the timezone of the node author, which is more logical (I still have quite a few 1.x things to adapt). Later I'll probably add a setting to choose a tribune's timezone in its edit form, but... as long as this is called a tribune I just can't have different clocks for different users.

And I'm somewhat sorry, but totozes, markup, the top-to-bottom order of messages, the absence of a pager, and clocks just have to stay that way, at least by default.

I'm going to see how I can give the option of using an input filter or something, that would be nice (and it would allow people who really want it to use BBCode).

The general settings page will eventually disappear, I just haven't got around to writing all the updating code needed for that.

And thanks for the RSS changes, that's another thing I had forgotten to attach to each tribune in the 1.x -> 2.x change (RSS readers that need these extra attributes are broken, though, the standard doesn't require them, and Liferea doesn't either).

So, I've commited a few things, but French or not (and I see totozes on quite a few non-French tribunes), many fundamental things will just stay that way.

Gyt’s picture

Title: BBCode, User's timezones + RSS improvements » Id reference, User's timezones and RSS improvements
Status: Needs review » Needs work
StatusFileSize
new1.65 KB

OK. Once again I ask, why you use "clock reference" but not "id reference"? Every tribune post have unique id but not have unique time. User's timezones will be work fine with id reference and we can make note like "SeeSchloss<" a link to referenced post.

Maybe Opera's feed reader is broken, but anyway RSS without titles and links not be useful. First of all, I see on a RSS title (truncate tribune post). If I find something interesting, I'm click to link (tribune node). I provide patch ($replacements don't needed, because we replace all tags in tribune.sleep.inc). Tribune input format will be a great feature (native BBCode not, you right)!

I like totozs idea, but I not find english totozs anywhere :(

SeeSchloss’s picture

Status: Needs work » Needs review

Clocks are a visual and informative way of referring to another post. Clocks are also unique as multiple posts during the same second are differentiated by the use of ¹, ², ³, or ":n" for subsequent posts (well... unless there's a bug somewhere). Using "SeeSchloss<" is useless for parallel discussions, which are typically very well separated in tribunes (even two different discussions between two same users).

You may very well not like all that, but these tribune "standards" have evolved to what they are now over the eight past years or so, and I like them that way, and all existing tribune users expect them, really, I can't stress enough that I'm only following well-established (in the small world of tribunes, sure) standards, and that I have to. I also think they are clearly superior to less intuitive things like using IDs or other meaningless numbers, but heh...

Thanks for the patch, it's now commited :)

As for totozes, yeah I do not know of an english-language totoz.eu-like website, I have seen http://static.apolyton.net/forums/images/smilies/ used as a totoz server though (http://apolyton.net/forums/misc.php?do=getsmilies for the list), but it does not seem very interesting to me. Setting up a totoz.eu clone wouldn't be that difficult though (or maybe contact the owner in order to find an internationalization solution?), it is just a place where people can send small pictures, after all. It could even be done as a drupal module, to run on the same website as your tribune, actually.

SeeSchloss’s picture

I have just committed changes to allow using drupal input formats instead of the default tribune one. I'm not making the tribune format (i, b, u, s allowed, m translated to ====> Moment <====, everything else html-escaped) as I doubt it would be useful anywhere else, and it would also make it a bit more complicated to have it as the default format, I think.

The standard filters aren't very useful, though, as they are meant to be used for blocks rather than lines of text.

Anyway, anyway

naheemsays’s picture

Thanks for all the hard work - much appreciated, evne if it does not work out as well as some (including me) envision is possible.

SeeSchloss’s picture

Status: Needs review » Closed (works as designed)