Settings page menu for coder review does not display. Patch attached.

Change description to include coder upgrade in some fashion (patch makes a change to point this out).

CommentFileSizeAuthor
coder_review_menu.patch1.47 KBsolotandem

Comments

stella’s picture

Status: Active » Fixed

That is a valid bug, but that's not the right patch I'm afraid. admin/settings/coder and admin/development/coder are both defined in coder.module. It's incorrect to add a menu definition for them to coder_review.module, as these paths should still be available to coder_upgrade if coder_review is not enabled. Instead coder.module implements hook_menu_alter() which changes the callback settings. I've committed a fix which explicitly sets drupal_get_form() as the default page callback in the menu alter, which fixes the problem.

Cheers,
Stella

solotandem’s picture

Status: Fixed » Active

I agree (forgot about the menu definitions in the coder.module file). While you are at it would you change the description on the 'admin/development/coder' menu too? (I reopened for this reason instead of another issue.)

stella’s picture

Status: Active » Fixed

I had changed the menu description for admin/settings/coder, but missing the admin/development/coder one. I've committed this change now. I changed the wording slightly for the admin/development/coder menu item. We should possibly revisit these descriptions too and describe them more accurately.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.