Jump to:
| Project: | Similar By Terms |
| Version: | 6.x-1.18 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi there,
As part of a project I'm working on, I've been trying to implement Panels 3 support for this module.
Here's the work I've done so far.
Besides the patch against similarterms.module to get Panels (via CTools) to pick up that we have something to add, I've attached the content type as similarterms.inc, which should be put in a new folder, similarterms/plugins/content_types.
To attain feature parity with the standard blocks, there's need of some refactoring of the current code. The similarterms_list function currently derrives its configuration from the vocabulary id and some database variables. That's a fine approach for the blocks system, since the vocabulary corresponds to the block delta, and each block can only be one place at time. For Panels, we would need something different, since similar terms for the same vocabulary could easily be used in different places with different configurations.
So I propose splitting similarterms_list in two, a part that deals with the configuration based on the block delta (that we can skip when providing configuration via Panels) and a second part that just takes the configuration and makes a list from it.
If that approach is acceptable to you, I shall be happy to implement it and make another patch :)
| Attachment | Size |
|---|---|
| hook_ctools_plugin_directory.patch | 837 bytes |
| similarterms.inc_.txt | 3.02 KB |
Comments
#1
I have no problem breaking that function up into smaller pieces. Is the included patches complete or just a start with the exception of including the split code for similarterms_list?
Thanks
Robert
#2
The included patch is just for including similar terms as-is, without the ability to customise it. I'll whip a larger one together with more configurability.
#3
mikl,
Great. If you want to though in views support as well. I would be happy to take that as well. Views support has to be my oldest open ticket.
Thanks
Robert
#4
Hi Robert,
Sorry for the lack of updates to this, but as it turned out, the client needed something a lot more specific to their site that what similar terms can offer (not only similarity by terms, but also date filtering and a couple of relations spanning node references), so we had to roll our own instead.
Thus, we are not going to use similar terms for the project, and I'm currently a bit too booked to work on it in my spare time. Sorry :(
#5
1.x branch is now closed and 2.x is views based. Going to mark this as fixed.
Thanks
Robert