"Don't create new revision" in revisions tab
neochief - May 31, 2009 - 19:20
| Project: | Vertical Tabs |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Dave Reid |
| Status: | closed |
Description
Hello.
When you don't have 'administer content' permission, in your node form there's a revision tab, and it doesn't contains the "Create a new revison" checkbox. But it is enabled by default under the hood, so, you will create a new revision on form submit.
So, the bug is that vertical tab contains "Don't create new revision" text, that is wrong, because you _are_ creating a new revision. Here's a patch to fix this bug.
| Attachment | Size |
|---|---|
| vertical_tabs.patch | 692 bytes |
#1
Seems like the text should be omitted entirely if the option doesn't exist. This patch isn't necessary correct if the default setting for the content type is to not create a new revision and a user doesn't have administer content permission.
#2
If default settings for content type is not to create revision and you have no administre rights, you'll see no revision tab at all. I tested it ;)
But I agree with your point about empty message. Here's a new patch.
#3
#4
Will get committed tonight.
#5
Tested that the revision information tab doesn't come up if the user doesn't have admin nodes permission, tested with create story permission and access disabled on the 'Create new revision' checkbox, and got the bug as discovered and fixed with the patch. Committed to CVS (http://drupal.org/cvs?commit=285310). Thanks!
#6
Automatically closed -- issue fixed for 2 weeks with no activity.