Hello.

When you don't have 'administer content' permission, in your node form there's a revision tab, and it doesn't contains the "Create a new revison" checkbox. But it is enabled by default under the hood, so, you will create a new revision on form submit.

So, the bug is that vertical tab contains "Don't create new revision" text, that is wrong, because you _are_ creating a new revision. Here's a patch to fix this bug.

CommentFileSizeAuthor
#2 vertical_tabs.patch945 bytesneochief
vertical_tabs.patch692 bytesneochief

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Needs work

Seems like the text should be omitted entirely if the option doesn't exist. This patch isn't necessary correct if the default setting for the content type is to not create a new revision and a user doesn't have administer content permission.

neochief’s picture

neochief commented
Status: Needs work » Needs review
StatusFileSize
new vertical_tabs.patch945 bytes

If default settings for content type is not to create revision and you have no administre rights, you'll see no revision tab at all. I tested it ;)

But I agree with your point about empty message. Here's a new patch.

alexanderpas’s picture

alexanderpas commented
Status: Needs review » Reviewed & tested by the community
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: Unassigned » dave reid

Will get committed tonight.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Tested that the revision information tab doesn't come up if the user doesn't have admin nodes permission, tested with create story permission and access disabled on the 'Create new revision' checkbox, and got the bug as discovered and fixed with the patch. Committed to CVS (http://drupal.org/cvs?commit=285310). Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.