VersioncontrolSvnLogHandler does not implement Countable, doesn't return the number of commits added
dhax - May 31, 2009 - 19:32
| Project: | Version Control API -- Subversion backend |
| Version: | 6.x-1.0-rc1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | sdboyer |
| Status: | active |
| Issue tags: | gsoc2009-dhax |
Jump to:
Description
When a Subversion repository fetches new logs, it sets a message telling how many commits it added. The problem is, it uses count($revisions) to set the message to the user (versioncontrol_svn.log.inc:129), which always returns 1.
Implementing Countable would let count() return the correct result.
#1
Rebranding: chrono325 → dhax
#2
Oooh, I missed that, The
count()call is a leftover from the original code. I'll have a look at this, and see if it's more prudent to implement Countable or do it by some other means.