On the product feature form, I checked "Override the title of the add to cart button." and set the button title to be "Donate", but it still says "Add to Cart". From the code, it appears that add_to_cart_title isn't actually being used.

CommentFileSizeAuthor
#16 uc_varprice-add-to-cart-title-not-being-used-478796-16.patch653 bytesAnonymous (not verified)
#15 uc_varprice-add-to-cart-title-not-being-used-478796-15.patch666 bytesAnonymous (not verified)
#9 uc_varprice.zip18.22 KBjpshayes
#1 add_to_cart_btn.patch570 bytesGarrett Albright

Comments

Garrett Albright’s picture

Garrett Albright commented
Status: Active » Needs review
StatusFileSize
new add_to_cart_btn.patch570 bytes

Yeah, what's up with that?

agerson’s picture

agerson commented

subscribe

agerson’s picture

agerson commented
Status: Needs review » Reviewed & tested by the community

Thanks Garrett. This fixed the problem on my site.

rszrama’s picture

rszrama commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Rob_Feature’s picture

Rob_Feature commented
Status: Closed (fixed) » Active

Hmmm...I'm having this issue using the rc3....which version was this fix committed to?

Jackinloadup’s picture

Jackinloadup commented

It looks like this patch was committed to the HEAD but there has not been a release since it was committed.

@rszrama can you please push a new release with this patch?

Jackinloadup’s picture

Jackinloadup commented

bump

jpshayes’s picture

jpshayes commented
StatusFileSize
new uc_varprice.zip18.22 KB

attached is the rc3 version of UC Variable Price module patched with patch from #1. Seems to be working fine.

hixster’s picture

hixster commented

The patched module doesn't seem to be working for me? I've entered a new button and amount field title, but they both reset to default one the form is submitted?
Have cleared caches but no joy?

hixster’s picture

hixster commented

So, we have managed to get the patch working, user error , I didn't realise the 'Check this box to add a default product feature to every product of this class using these settings' needed to be on. We really only want to change the button text. it would be nice to change the button submit text without the need to have the product become variable priced.

Essentially it would be nice to de-couple the button renaming for a product class from the variable price functionality.
I know that's slightly contradictory given the nature of the module :-)

Is there an existing module that allows button override by class? I'm aware we could use hook_form_alter , but it seems the guts of this functionality and particularly the ability to apply by class is already there.

smira’s picture

smira commented

this patch should be committed

cehfisher’s picture

cehfisher commented

I know this is an old post, but is there a D7 patch for this? I cannot seem to get this to work using the latest D7 version of this module. I have set-up the product class correctly and have checked 'Check this box to add a default product feature to every product of this class using these settings', etc. I am starting to wonder if there is a module incompatibility in my set-up. Anyone get this to work in D7 or know of any module incompatibility?

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
StatusFileSize
new uc_varprice-add-to-cart-title-not-being-used-478796-15.patch666 bytes

Here's a tweak to the patch in #1 to get it working on D7. Works for me on a D7 Ubercart site, although I have not tested it rigorously. In this use case, the patch correctly shows the "Add to cart" title as defined in a varprice feature for this product.

This site is also running uc_atctweaks, but I don't think that is needed.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new uc_varprice-add-to-cart-title-not-being-used-478796-16.patch653 bytes

Update to patch in #15: fixed tiny whitespace error. :)