Closed (cannot reproduce)
Project:
Link
Version:
6.x-2.6
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Jun 2009 at 18:46 UTC
Updated:
23 Oct 2011 at 19:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
jesss commentedI'd like to test this. Can you reroll the patch against the latest version (6.x-2.6)?
Comment #2
jhedstromHere's the reroll against the latest version.
Comment #3
jesss commentedWhen I tried to apply the patch, all three hunks failed. It's entirely possible that this is user-error on my part -- I'm a complete novice to the patch process.
That said, when I made the changes to link.module manually, the code changes worked like a perfectly.
Comment #4
joachim commentedPatch applies cleanly with the latest release:
@jess -- do:
$ patch -p0 < link.478922.patch
Will report back once I've actually tried it on a site :)
Comment #5
joachim commentedConfirming this works.
You still need to run the data through link_cleanup_url(), in case users have entered "google.com" without a protocol. I'm doing this in my views template, but perhaps it would be nice to do this cleanup automatically? Would there be cases where that is not needed?
Comment #6
damienmckennaHere's a rerolled patch that includes a quick call on link_cleanup_url() before returning the link.
Comment #7
damienmckennaComment #8
crea commentedYou forgot to upload the patch
Comment #9
damienmckennaDoh! Sorry X-)
Comment #10
dqdI close this issue since it is too old to reproduce or commit. If this feature is still missing please start a new issue for that. thanks for the effort and for understanding.