Need replacement for comment_new_page_count()

We need this ASAP for advanced forum integration.

I should've marked myself assigned on this, I've got an in-progress patch that may or may not work for this problem, it's a bit more difficult than the comment.module implementation, since we need to get the assigned view then modify it's query to get the first page with a new comment.

After forcing the view to order by threaded or not based on the node type, which is an easier solution to administer, I then just adapted comment.module's function to this. http://drupal.org/cvs?commit=223350

I don't get what to do... I get the "Fatal error: Call to undefined function comment_new_page_count() in /.../../.../.../sites/all/modules/advanced_forum/advanced_forum.module on line 789
I don't understand what that link is ( http://drupal.org/cvs?commit=223350) or what to do. I just downloaded the latest AF for Drupal 6.12. I also downloaded the latest nodecomments for D6.
Heres my forum error link: http://stupidai.com/forum
*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
EDIT: They NEED to include ALL of these needed modules in Drupal 7 and I just gave up on trying to fix it...

I noticed that nodecomment in CVS started to get a number of comment_*() functions that replace comment.module. It sets these two on a collision course, unless comment.module is also patched to have "if (!function_exists(...))" clauses around functions that's being overridden. One place where it is destined to happen is admin/build/modules, where even disabled modules are loaded.

Just a thought... it seems to me that hook system in Drupal core should be capable of getting the job done for all overridden functions. My impression was that hook system was created specifically to avoid name collisions. Can something like this do the job?

$result = module_invoke_all('new_page_count', $num_comments, $new_replies, $node);
if (count($result) == 1) // Success!
  ...

I think this type of caller-side wrapper is more universal than having multiple-defined functions. Then each of the "comment"-providing modules will implement all of those as hook_*(). Best part of it is that it requires no patching of comment.module, and honors coding conventions.

Yes, I stay corrected, nodecomment in d.o ftp still has these, e.g:

if (!function_exists('comment_nodeapi')) {
  function comment_nodeapi(&$node, $op, $arg = 0) {
    return nodecomment_nodeapi($node, $op, $arg);
  }
}

But CVS -dev totally got rid of them. Sorry for rushing the conclusions.

Still, is there any merit in using hook api to resolve which module/function provides comments?

>Why would you want both nodecomment and comment to run each function?
They would not do that. I mean for AF and all other modules which would want to decouple from comment.module and allow nodecomment or any other comment engine.

Nodecomment.module only has to define nodecomment_*() functions that would replace comment_*() functions.

@Michelle
Which of the branches in CVS are you running for AF, NC and Views?

> I was talking about your proposed hook system which would run both the comment and nodecomment version for every call.
module_invoke_all() will only run enabled modules. nodecomment disables comment and vice versa, so module_invoke_all() will only run one function out of currently enabled module. It will return either one element array, or zero (if some module calls it without proper dependency on comment). Yes, it is off-label use of potent drug, but if it works, it works. Short of a proper provider API in core, it may be a best work-around.

Re: Versions
Is this list correct? (I'm still confused about Views)
AF: DRUPAL-6--2
NC: DRUPAL-6--2
Views: DRUPAL-6--2-6 (or HEAD? or DRUPAL-6--3?)

Thanks for the clarification. In admin/build/modules comment is greyed out and unchecked. Maybe it changed in CVS, but in nodecomment from ftp it was disabled, so I thought only one module is actually used. Good to know that now.

I will try Views HEAD first then.

Best,

iva2k: You say you're using Nodecomment 2 but it really sounds like you're using Nodecomment 1. I can say with some certainty that not only does Nodecomment 2 define any comment_* functions, it has comment.module as a dependency *and* the update script will try to enable comment.module in case you're upgrading from an older version. I think you somehow hoave the older version installed.

Not to mention, what you report has *nothing* to do with this issue anyway, so you've now added what looks like 20 or so comments to an unrelated issue. That's very confusing to everyone.