ereg_* functions give deprecation warnings under PHP 5.3. This patch replaces them with the equivalent preg_* function. I hope this is as straightforward as it looked.

CommentFileSizeAuthor
#7 ereg-2.patch2.33 KBthisgeek
ereg.patch2.23 KBludovicofischer

Comments

moshe weitzman’s picture

moshe weitzman commented

Anyone available to review this. Especially check that the log_messages changes work properly.

designerbrent’s picture

designerbrent commented
Status: Needs review » Reviewed & tested by the community

This patch seems to work for me

thisgeek’s picture

thisgeek commented

Definitely an improvement, but now I get a warning in place of the error:

preg_match(): Delimiter must not be alphanumeric or backslash in     [warning]
/usr/local/drush/includes/command.inc on line 521.

It seems to be unhappy with line 423 of the same file:
$files = drush_scan_directory($path, '\.drush\.inc$');

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Needs work

can someone comment on this error report?

droplet’s picture

droplet commented

convert that to 

$files = drush_scan_directory($path, '/\.drush\.inc$/');
moshe weitzman’s picture

moshe weitzman commented

can anyone confirm?

thisgeek’s picture

thisgeek commented
StatusFileSize
new ereg-2.patch2.33 KB

droplet seems to have fixed the problem I was having. I didn't run a full test, but all of the tasks I usually run work as I expect them to.

thisgeek’s picture

thisgeek commented
Status: Needs work » Needs review
moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Postponed

committed. thanks.

moshe weitzman’s picture

moshe weitzman commented
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.