fivestar_validate_target was not called in nodeapi view

birwel - June 2, 2009 - 20:00
Project:Fivestar
Version:6.x-1.15
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Here's the patch.
When your own module implements the MODULE_fivestar_access hook
this call isn't performed in a node view.

AttachmentSize
check_permissions_on_view.patch632 bytes

#1

quicksketch - June 2, 2009 - 20:59
Status:patch (to be ported)» reviewed & tested by the community

Looks correct to me, this bug has been fixed in the 2.x version (HEAD) already, but needs to be applied to the 1.x branches.

#2

quicksketch - June 30, 2009 - 23:18
Status:reviewed & tested by the community» fixed

Committed.

#3

quicksketch - June 30, 2009 - 23:57

Followup patch, the call to fivestar_validate_target() was incorrect, since the "type" in this case should be "node", not $node->type.

AttachmentSize
fivestar_validate_node.patch 1.98 KB

#4

System Message - July 15, 2009 - 00:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.