fivestar_validate_target was not called in nodeapi view

Posted by birwel on June 2, 2009 at 8:00pm

Issue Summary

Here's the patch.
When your own module implements the MODULE_fivestar_access hook
this call isn't performed in a node view.

Attachment	Size	Status	Test result	Operations
check_permissions_on_view.patch	632 bytes	Ignored: Check issue status.	None	None

Posted by quicksketch on June 2, 2009 at 8:59pm

Status:

patch (to be ported)

» reviewed & tested by the community

Looks correct to me, this bug has been fixed in the 2.x version (HEAD) already, but needs to be applied to the 1.x branches.

Posted by quicksketch on June 30, 2009 at 11:18pm

Status:

reviewed & tested by the community

» fixed

Committed.

Posted by quicksketch on June 30, 2009 at 11:57pm

Followup patch, the call to fivestar_validate_target() was incorrect, since the "type" in this case should be "node", not $node->type.

Attachment	Size	Status	Test result	Operations
fivestar_validate_node.patch	1.98 KB	Ignored: Check issue status.	None	None

Posted by System Message on July 15, 2009 at 12:00am

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.