This is a child task for #422380: Convert all core module to use new static caching API focusing on the block module.

CommentFileSizeAuthor
#3 jamesan_480112-3.patch1.66 KBJamesAn
#2 jamesan_480112-2.patch1.66 KBJamesAn
#1 jamesan_480112-2.patch1.63 KBJamesAn

Comments

JamesAn’s picture

JamesAn commented
Status: Active » Needs review
StatusFileSize
new jamesan_480112-2.patch1.63 KB

There are 3 static vars in the block module, none of which are ever reset. Comments were inserted to mark that.

I also made the following semantic change:

-  if (!count($blocks)) {
+  if (empty($blocks)) {
JamesAn’s picture

JamesAn commented
StatusFileSize
new jamesan_480112-2.patch1.66 KB

As mentioned in #480122-2: Update blogapi module to use drupal_static(), most static vars should be converted over to use the drupal_static() method.

JamesAn’s picture

JamesAn commented
StatusFileSize
new jamesan_480112-3.patch1.66 KB

Oops. Forgot the ampersand in front of drupal_static().

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.