subdir installs and boost_is_cacheable()
mikeytown2 - June 2, 2009 - 21:47
| Project: | Boost |
| Version: | 6.x-1.0-beta1 |
| Component: | Caching logic |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
regular expressions match the beginning $path, which now includes $base_path. $base_path should be set in boost_cache_directory() not in boost_init(). This will also help with the _boost_rmdir_rf() rewrite #477848: Difficulties w/ Boost 6.x1.0-alpha4 - Multi-site, Folder Permissions - _boost_rmdir_rf().
#1
shoot... the drupal/user page is getting cached; which can be used to login. drupal/user/login is not being served even though it is being cached.
#2
Newer rules to match whats in boost_cache_directory()
RewriteCond %{REQUEST_URI} (^/(admin|cache|misc|modules|sites|system|themes|user/(login|register|password))|(.xml|/(feed|comment/reply|user))$) [OR]Also found a bug this
<?php// Don't cache comment reply pages
if (preg_match('!^comment/reply!', $normal_path))
return FALSE;
?>
should be this
<?php// Don't cache comment reply pages
if (preg_match('!comment/reply$!', $normal_path))
return FALSE;
?>
#3
After testing, boost/drupal is smart enough to not fail even though the login page is cached.
Here's the new set of rules to go in; makes sure if this happens again, it will not even serve those cached pages if they do exist.
RewriteCond %{REQUEST_URI} (^/(admin|cache|misc|modules|sites|system|themes))|(/(feed|comment/reply|user|user/(login|password|register))$) [OR]#4
proposed changes
#5
minor fixes to above patch
#6
here's the correct file
#7
j/k its here... i need to get some sleep.
#8
committed
#9
Automatically closed -- issue fixed for 2 weeks with no activity.