This is a child task for #422380: Convert all core module to use new static caching API focusing on the search module.

CommentFileSizeAuthor
#6 480430-6.patch1.31 KBJamesAn
#1 jamesan_480430-1.patch1.31 KBJamesAn

Comments

JamesAn’s picture

JamesAn commented
Status: Active » Needs review
StatusFileSize
new jamesan_480430-1.patch1.31 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented 
+  $last = &drupal_static(__FUNCTION__);
+  $lastsplit = &drupal_static(__FUNCTION__ . ':lastsplit');

should be

+  $last = &drupal_static(__FUNCTION__ . ':last');
+  $lastsplit = &drupal_static(__FUNCTION__ . ':lastsplit');

IMO.

catch’s picture

catch
he/him
Primary language English
commented

Dries, the update docs specifically say to keep __FUNCTION__ only for the first static var, the reason being that drupa_static_reset() will clear all statics together if you do that. See http://drupal.org/node/224333#static_variable_api

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

JamesAn’s picture

JamesAn commented
Status: Needs work » Needs review
StatusFileSize
new 480430-6.patch1.31 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch failed testing.

Status: Needs work » Needs review

Re-test of 480430-6.patch from comment #6 was requested by Arancaytar.

cburschka’s picture

cburschka
they
commented

The failure looks unrelated and is also old. However, it is likely the patch doesn't apply anymore now.

cburschka’s picture

cburschka
they
commented
Status: Needs review » Reviewed & tested by the community

If it's passing, it looks RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks for catching these stragglers. Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.