By metazoid on

The bounty for this task is $50 paid via paypal and what I am looking for is a patch for the Advanced Forum 6.x-1.0 to work with the OG Forum 6.x-1.4. Currently the two modules do not interact well as Advanced Forum module causes the Forum select drop down box in the forum topic creation page to not display the taxonomy of the Organic Group that the OG Forum corresponds to thus making the post orphaned until a administrator comes in and selects the correct taxonomy which makes it show up correctly.

What happens when an authenticated user who is part of the group goes to the topic creation page is that the group will appear in the forum select drop down box and the post can be submitted without any errors. However, once the user goes back to the OG Forum of the group the post does not display but it can be access via the main forum under the last post column. As the super admin I checked the content link in the admin panel which lists all the nodes created and the topic that was posted in the OG Forum shows up in the forum select drop down box as "Please Choose" indicating that the taxonomy of the OG Forum was not assigned when the authenticated user assigned it in the original creation of the post. As the super admin I can assign the taxonomy which causes the post to actually appear in the correct place.

I'm looking for someone who is willing to work on this issue and not just deliver a patch in case the first attempt at the patch fails. Also once its developed I don't mind about distribution to the community, I would imagine a few people would really appreciate the resolution of this issue.

⋅ Categories: Drupal 6.x

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

It's been a while since I've looked at OG Forum but I'm very surprised if that's the only issue you're having. When I last looked, they totally clobbered each other and it was more of a mess than I was interested in trying to fix. OGF must have changed considerably since then.

I can't think what in AF could possibly be causing the problem you're describing but, if that is the only remaining conflict with OGF, I'd be interested in a patch once you have it. There have been several people looking to integrate the two modules.

Michelle

metazoid’s picture

metazoid commented

Well its sad but from the looks of it it appears that nobody is interested in creating a patch even though their is a monetary reward for what I would call a pretty simple task for a experience Drupal developer. I'll keep working on the issue myself trying to figure out a solution but I really haven't even been able to isolate the problem.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Ah, that's too bad. I'm not sure how simple it is, though. I haven't dug into it but I can't think of anything off hand that would cause it. AF doesn't really do anything with the add/edit pages yet. You're offering about 30 minutes to 1 hour of pay and it may be that folks think it would take longer than that to unravel the problem.

If you manage to isolate the problem, that would help a lot.

Michelle

metazoid’s picture

metazoid commented

Okay well since I started on this I've made some significant progress as I found out the problems lies with the OG Forum and not Advanced Forum. There was a minor bug in the hook_form_alter that prevented the correct taxonomy showing up in the drop down box and this is compounded by a error in the function og_forum_db_rewrite_sql which I have yet to track down but when I completely removed that function from the OG Forum module file the created topics worked perfectly. However, since that function controls the visibility of the forum and topics it is essential to keep in the module but I haven't found the specific error to be able to correct it. With this information I'd still be willing to pay the bounty if someone can come up with a patch but I'll keep working on the problem as well.

tjmoyer’s picture

tjmoyer commented

I've been working on this same issue. It seems that when a group member posts a new topic to the forum there is no $tid provided for forum.module to insert into the forum table in the database (line 280+, forum.module, part of the forum_nodeapi function):

    case 'insert':
      if (!empty($node->tid)) {
        db_query('INSERT INTO {forum} (tid, vid, nid) VALUES (%d, %d, %d)', $node->tid, $node->vid, $node->nid);
      }
      break;

However, this only occurs when the user does not have 'administer forums' permissions enabled. Once that permission is enabled it works fine. Any ideas on why $tid is not available with this permission set?

tjmoyer’s picture

tjmoyer commented

I've found that the $node object is missing the tid when the new forum node is being saved. To solve this (though it's not a patch within og_forum), I have used hook_nodeapi with the following code to ensure the tid is included:

function yourmodulename_nodeapi($node, $op, $teaser = NULL, $page = NULL) {
  switch ($op) {
    case 'presave':
      if (!isset($node->tid)) {
        $node->tid = arg(3);
      }
    break;
  }
}

This ensures that the tid is passed on, so the forum is added to the database.

Still testing and looking for any other issues. If any of you can point out known issues to look for, let me know.

robertdjung’s picture

robertdjung commented

subscribe

dazweeja’s picture

dazweeja commented

@metazoid, I think I've solved your issue and a few other integration issues with advanced_forum and og_forum co-existing. However, I've been working off og_forum 6.x-2.x-rc2 which solves some other issues with og_forum (showing a 'Forums' tab on the Group home page, etc). I've posted the patch in #386566: OG Forum incompatible with Advanced Forum 6.x.2