Fivestar comments duplicating comments

Intertextual - June 3, 2009 - 10:03
Project:Fivestar
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

When enable fivestar comments duplicates comments. Please see image attached.

AttachmentSize
fivestar comment.png9.8 KB

#1

quicksketch - June 3, 2009 - 22:26
Category:bug report» support request

This looks like something caused by your theme. Check your comment.tpl.php file and make sure that the $content variable is being printed once. Try switching to a core theme like Garland and you should see that this problem does not exist there.

Also, the 2.x version is far from stable and I'd suggest not using it for any production purposes.

#2

Intertextual - June 5, 2009 - 15:08
Category:support request» bug report

Well, it seems it's not related to comment.tpl.php see code below:

  <div class="comment<?php print ($comment->new) ? ' comment-new' : ''; print (isset($comment->status) && $comment->status  == COMMENT_NOT_PUBLISHED) ? ' comment-unpublished' : ''; print ' '. $zebra; ?>">
 
    <?php if ($picture) { print $picture; } ?>

    <?php if ($comment->new): ?>
      <span class="new"><?php print $new ?></span>
    <?php endif; ?>

    <div class="commentTitle">
      <?php print $title; ?>
    </div>

    <div class="submitted">
      <?php print $submitted ?>
    </div>

    <div class="content">
      <?php print $content ?>
      <?php if ($signature): ?>
        <div class="user-signature clear-block">
          <?php print $signature ?>
        </div>
      <?php endif; ?>
    </div>

    <div class="links">
      <?php print $links; ?>
    </div>
  </div>
 

Anyways, I will use version 6.x-1.15

Thanks a lot.

#3

quicksketch - June 5, 2009 - 15:47

Do the comments display correctly when you switch the theme to Garland? I know this doesn't occur on a fresh installation, so we're probably seeing a conflict with some other code in Drupal.

#4

brisath - June 30, 2009 - 17:05

Subscribing

#5

Kars-T - July 1, 2009 - 13:35

fivestar_comment.module line 144 is

<?php
$comment
->comment .= theme('fivestar_comment_view', $comment->comment, $comment->fivestar_view);
?>

.= ofcourse doubles $comment->comment. Removed it and everything is fine again. :)

AttachmentSize
fivestar_comment.module.patch 844 bytes

#6

Kars-T - July 2, 2009 - 08:45
Status:active» needs review

I forgot to set this to "needs review" sorry

#7

quicksketch - July 2, 2009 - 15:11
Status:needs review» reviewed & tested by the community

Looks right to me, I'll commit next time I'm working on 2.x.

#8

ezra-g - August 27, 2009 - 21:13
Status:reviewed & tested by the community» fixed

Committed, thanks!

#9

System Message - September 10, 2009 - 21:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.