We have several blocks on the right side, but for some reason when I visit the advanced blog page, it disappears from there and goes to the bottom left of the site.
See here: http://www.4242.hu/hu/advanced_blog/list

I was wondering why would it happen when a friend of mine told me that for example non-closed html tags could cause such. Then I validated the page and really:
W3 Validator results
It has several double-opened <p> tag and div around the "about" div...

A sidenote: Though I found several bugs in the module, it's an impressive work and I thought as soon as they'll get fixed, I'll love it so thank you :)

CommentFileSizeAuthor
#18 advanced_blog.patch3.71 KBPaul Lomax
#14 advanced_blog.patch3.49 KBPaul Lomax

Comments

fleetcommand’s picture

fleetcommand commented

Eh. Wrong url to the validator.. it
should be this

fleetcommand’s picture

fleetcommand commented

I have found the error.. It's in line 512:
$blogger .= '<div class = "about"><h1>' . theme_username($account) . '</h1><p>';
Should be
$blogger .= '<div class = "about"><h1>' . theme_username($account) . '</h1></div>';

I replaced the wrong line in the module, so when you click the links I provided earlier, it will show you the site is validating now.

eidolon night’s picture

eidolon night
Location Batavia, NY
commented
Assigned: Unassigned » eidolon night

Thanks for the catch. I'll put this in the next dev release.

eidolon night’s picture

eidolon night
Location Batavia, NY
commented
Status: Active » Needs review

Updated in latest dev.

marcus0263’s picture

marcus0263 commented

Didn't have the problem until this latest dev release, now Blog list is badly formated. Updated Jun 25, here's the view

http://www.rejecttheherd.net/advanced_blog/list

fleetcommand’s picture

fleetcommand commented

Well marcus, it's access denied for us, so we cannot see what looks wrong :)

However, I assume that the blogger's name and the word "Posts" is what you have in a wrong position. Well, that's a css problem then. If I'm correct and that's what you mean, then see the advanced_blog.css file:
.about {
float: left;
}

Then comment out that "float: ..." line. That will help. If not this is what you're looking for, then you need to specify it :)

marcus0263’s picture

marcus0263 commented

Aaah, I fixed the "permissions" you should be able to see it now.

Anyway, that "helped" but if you take a look at the site there listing of the Bloggers is still a bit out of whack. Some are indented in (top few) and as you go down the list they slide all the way to the left. Plus the Blogger names are still out of whack.

I've also reproduced this with the Garlend Theme also.

Thanks for looking into it.

marcus0263’s picture

marcus0263 commented

Here's the badly formated page with the Garland Theme

http://pix.rejecttheherd.net/d/6079-1/advblogerr.png

Cheers

marcus0263’s picture

marcus0263 commented

Validating the page it finds a number of errors, example

Line 86, Column 320: document type does not allow element "li" here; missing one of "ul", "ol" start-tag
…div class = "about"><p></p></div><li><a href="/node/"></a></li><ul><li><a hre

Line 86, Column 999: document type does not allow element "li" here; missing one of "ul", "ol" start-tag
…div class = "about"><p></p></div><li><a href="/node/"></a></li><ul><li><a hre

Line 86, Column 1499: document type does not allow element "li" here; missing one of "ul", "ol" start-tag
…div class = "about"><p></p></div><li><a href="/node/"></a></li><ul><li><a hre

Line 86, Column 1499: document type does not allow element "li" here; missing one of "ul", "ol" start-tag
…div class = "about"><p></p></div><li><a href="/node/"></a></li><ul><li><a hre

Line 86, Column 3282: end tag for element "div" which is not open
…i></ul></div></div></div></div></div><div style="clear:left"><h2 class="title

Line 86, Column 3603: document type does not allow element "li" here; missing one of "ul", "ol" start-tag
…div class = "about"><p></p></div><li><a href="/node/"></a></li><ul><li><a hre
fleetcommand’s picture

fleetcommand commented
Version: 6.x-1.0-beta1 » 6.x-1.x-dev

Then it must be a new issue in the -dev version. When I applied the modifications to beta1, it looks fine (see here: http://www.4242.hu/hu/blogs ).. however, when I tried -dev a few days ago, I also ended up with a wrong page (which had the same html validation errors as you posted). So -dev has a new issue about this. Maybe I'll track it down this evening if noone will do that by then.

fleetcommand’s picture

fleetcommand commented

Ok, I found two errors in the current (june 24) dev version:

check the .module file around line 516..

it looks like this

  $blogger .= '<div class = "about"><p>' . $info . '</p></div>';
  $blogger .= '<li>' . l($post->title, "node/$post->nid") . '</li>';
  $blogger .= '<ul>';
  while ($post = db_fetch_object($find)) {
    $blogger .= '<li><a href="/node/' . $post->nid . '">' . $post->title . '</a>
  }
  $blogger .= '<li>' . l("more...", "blog/$uid") . '</li>';
  $blogger .= '</ul>';
  $blogger .= '</div></div></div></div>';
  $output .= theme_box('', $blogger, $region = 'main');
  $output .= '<div style="clear:left">';

modify like this:

  $blogger .= '<div class = "about"><p>' . $info . '</p></div>';
  //
  // PUT THIS NEW LINE HERE:
  $blogger .= '<ul>';
  $blogger .= '<li>' . l($post->title, "node/$post->nid") . '</li>';
  //
  // COMMENT THIS OUT:
  // $blogger .= '<ul>';
  while ($post = db_fetch_object($find)) {
    $blogger .= '<li><a href="/node/' . $post->nid . '">' . $post->title . '</a>
  }
  $blogger .= '<li>' . l("more...", "blog/$uid") . '</li>';
  $blogger .= '</ul>';
  //
  // WE HAVE MORE DIV CLOSED THAN NEEDED. SO INSTEAD OF THIS:
  // $blogger .= '</div></div></div></div>';
  //
  // PUT THIS IN:
  $blogger .= '</div></div></div>';
  $output .= theme_box('', $blogger, $region = 'main');
  $output .= '<div style="clear:left">';

I hope this helps. Also, Eidolon, please fix it in the -dev.

Btw I don't see where the last div clear:left is closed and what is it used for, but now the page validates. I hope this is a correct way to fix this issue.

marcus0263’s picture

marcus0263 commented

Well it now validates and the page isn't as badly formed any longer. This page does still needs a lot of work though, like the double listing of Bloggers username and the exta "dot" on top of the Bloggers blog list.

I wish I knew CSS and HTML so I could help fix it, but I don't.

Paul Lomax’s picture

Paul Lomax commented

The problem is this right here

Line 523
$output .= '<div style="clear:left">';

a) Its a style in the markup
b) Its a hack
c) It doesn't have a closing

I'd say remove this line altogether, put a float on the main container element and a width of 100%.

Paul Lomax’s picture

Paul Lomax commented
StatusFileSize
new advanced_blog.patch3.49 KB

This patch should fix most of the issues on that page.

  • Changed all the links to use the l() function so they still work if you don't have Pathauto, and/or short URL's.
  • Removed a lot of extraneous markup, it served no purpose, it should now validate properly
  • Changed a couple of styles to improve the default layout slightly.
  • Added a check to see if the Blog has a name set, if it does then it will use that as the title in the list.
  • Added a check to see if there is a description set, if it doesn't it wont display the empty paragraph tags.
  • Changed the title of the blog so it links to the blog itself rather than the users page.

I think they are all pretty logical changes, enjoy.

marcus0263’s picture

marcus0263 commented

Thanks, applied the patch but Hunk 1 and 2 puked ..

patching file advanced_blog.css
patching file advanced_blog.module
Hunk #1 FAILED at 480.
Hunk #2 FAILED at 501.
Hunk #3 succeeded at 542 (offset 9 lines).
2 out of 3 hunks FAILED -- saving rejects to file advanced_blog.module.rej
ggevalt’s picture

ggevalt commented

Hi,
I placed the patch code in the .css and .module files. I then enabled the Bloggers block. It appeared as a block just fine, but then had this problem when I clicked "more" to the page view:

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '@@ -502,25 +501,24 @@ AND users.uid = 0 ORDER BY node.created DESC ' at line 3 query: SELECT * FROM node node @@ -502,25 +501,24 @@ AND users.uid = 0 ORDER BY node.created DESC LIMIT 0 , 5 in /var/www/html/youngwritersproject.org/sites/all/modules/advanced_blog/advanced_blog.module on line 501.

Needless to say that below the many warnings was a page that didn't look very good.

I doublechecked to make sure I had properly updated the coding on the Beta1 version, so either I just can't see an error I introduced, or the patch doesn't quite have all the fixes.

I tried the blogroll which did not list anything and I could not see how to set it to pull list... and blog info block did not appear.

This was a quick look see. I hope this helps. Let me know if you'd like us to test anything for you on a local site. This module would be of great use to us.

Thanks for your efforts.

Geoff

toma’s picture

toma commented

I am using the last dev version in my website, and it does use an error to display

also it doesn't show the user picture nor the url path

you can check here

http://elbarca.com/advanced_blog/list

Paul Lomax’s picture

Paul Lomax commented
StatusFileSize
new advanced_blog.patch3.71 KB

Okay, firstly sorry, my fault, that patch was built on the beta1 version. My bad.

Here is a version for the 6.x-1.x-dev copy, i've made a few other alterations too like added a placeholder if there is no user profile pic selected.

ggevalt: you haven't patched it properly, you need to use a version control system to apply the patch, download and install TortoiseSVN, once its installed you should have a new option on right click menu. Right click the patch file and choose TortoiseSVN > Apply Patch then navigate to the advanced_blog module folder and hit ok. A window will pop up with all the code, right click on one of the files in the small window and choose 'Patch all'.

There are many ways of doing this but this is probably one of the easier ones.

toma: This patch should fix most of your problems.

This module really needs some more work, all this stuff should be in theme functions in an ideal world, but I don't really have the skills or time to do it. Its a pretty handy module and has some nice functions but its all a little bit hacky.

Anyway I hope this helps some people.

ggevalt’s picture

ggevalt commented

tigerfish,

thanks for all your work. And thanks for the advice regarding the patch. I confess to having gone to the dark side, or, rather, to the enlightened side, depending on your point of view: I now use Macs. So Tortoise is a great program that I used while on a PC but have not found an equivalent for Macs. However, I will try it out with our PC and see how that works. And then we'll try out the module.

Thanks again.

g

toma’s picture

toma commented

is it #18 apply to a dev version of the release, because i just download the dev but still get the same issue!

Paul Lomax’s picture

Paul Lomax commented

Toma: There hasn't been any updates by the maintainer of this module for a couple of months so you'll have to apply the patch in post #18 yourself. Download the -dev version and the patch file then follow the instructions to use SVN to patch it.

dailypress’s picture

dailypress commented

example.com/advanced_blog/list

my footer changes completely. it turns light gray and the year 2009 is shifted to the top right corner covered behind my background!! ??

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Component: Code » User interface
Assigned: eidolon night » svendecabooter
Status: Needs review » Fixed

The advanced_blog/list page has been cleaned up and refactored as part of my ongoing process to cleanup this module.
The latest HEAD version of this module produces valid HTML output, and is themeable through the Drupal theme system.

Part of the work done by Tigerfish Paul has been incorporated into the latest code. Thanks for providing the patch Paul!

A new release of this module will be released in a while, once the cleanup & fixing process has been finished.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.