Getting Javascript error dialogs in IE6, could be caused by the combination of this and the related menus module. For example clicking on the 'create content' menu item causes a this.parentNode is null error.

CommentFileSizeAuthor
#4 patch_001_0.txt1.64 KBpauls-1

Comments

jjeff’s picture

Yes, I need to take a look at the way things are (not) working in IE. Please post more errors here if you find them. Hopefully I will have a chance to take a look this week.

-Jeff

pauls-1’s picture

here is a patch i came up with that seems to function in ie 6 and doesnt break the existing ff compatibility.

    Element.addClassName(lis[lis.length - 1], 'last');
-  firsta.flip = function() {
+  firsta.onclick = function() {
+    if (this.parentNode){
        myul = this.parentNode.getElementsByTagName('ul')[0];
        vis = Element.visible(myul);
        Element.removeClassName(this, vis ? 'expanded' : 'collapsed');
        Element.addClassName(this, vis ? 'collapsed' : 'expanded');
        Element.removeClassName(this.myli, vis ? 'expanded' : 'collapsed');
        Element.addClassName(this.myli, vis ? 'collapsed' : 'expanded');
        new Effect.toggle(this.parentNode.getElementsByTagName('ul')[0], 'blind');
+    }
+    return false;
    }
-   Event.observe(firsta, 'click', firsta.flip);}
+   Event.observe(firsta, 'click', firsta.onclick);}
}

you can actually safely remove the line:
Event.observe(firsta, 'click', firsta.onclick);
and ie 6.0 and the latest ff still function correctly.
not sure if it is in there for further compatibility beyond those two..

pauls-1’s picture

forgot to mention target file is spajax.js lines 41-53

pauls-1’s picture

StatusFileSize
new1.64 KB

after reviewing the patch submission docs im submitting a cvs diff.

pauls-1’s picture

Status: Active » Needs review

status to patched. see previous attachment.

pauls-1’s picture

Status: Needs review » Needs work

still need to get the detached menu to work.. changing status

artusamak’s picture

Status: Needs work » Closed (won't fix)

This issue is against a version of Drupal that is not deprecated.
This is a cleaning comment, if your issue is still valid, please open a new issue against the latest branch.