Add choices for the <itunes:author> source
drewish - June 3, 2009 - 17:09
| Project: | iTunes |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Following up on #480192: Add <itunes:keywords>, <itunes:author>, and <itunes:duration> elements. where we added the <itunes:author> element we should make it more flexible on where we get the author name from. I'd like a per-node-type option that's either: "- None -", Node Author, or any of that type's CCK text fields.
#1
I got it working, will submit the patch tomorrow. I was just wondering, maybe CCK User Reference would be best for this (we can leave CCK textfield too).
#2
Hey Drewish, here's the patch against -dev. I'm sorry, I have no CVS access at work but I made a patch for multiple files with diff. Some file timestamps are wrong too because I started to work before your last commit. Hopefully I'll improve myself with CVS and patches !
Anyway, the patch allows to choose the source for itunes:author between :
- none
- node author
- a CCK Text Field of this nodetype, but textareas are not allowed : we obviously want something short for itunes:author
- a CCK User Reference field of this nodetype, and if multiple values are provided, they are imploded in a comma separated string
Let me know !
Guix
#3
I haven't tested it but just looking at the patch that looks great. I'll be back in a few hours and take a look at it then.
#4
Hello Drewish, any updates on this ? If you prefer I can re-roll a patch against CVS with the good file timestamps.
#5
okay i liked your choice of source naming and decided to rename the rest of the variables to match it. i also did a little clean up around it but it shouldn't be too different from your code. might taking a look at it? it probably needs some work.
#6
I just found a typo in a variable name, otherwise I've reviewed and tested the code and everything is clean. I added some fixes for warnings found by Coder, too. I just hope you can work easily with the multiple files patches I did with diff (I've asked for CVS acces @work but it should take some time... IF I get it). See you !
#7
I now have CVS access at work and I re-rolled a patch against CVS, is it more usable for you ?
#8
I like where this module is going, but what if someone is using a node reference (as the author) to point to a staff page?
I suppose that someone could use nodeapi and get the node reference and insert it to the "node author" field on presave.
*Updated*
Never mind, I see where there is a userreference!
#9
In the new admin page, there is an issue with the Vocab and the default selected value. I've rolled a patch to catch this.
#10
committed JaredAM's patch to HEAD.
also committed the documentation and white space changes from guix on #7. i'll re-roll a clean version of the patch in a minute.
#11
here's what's left of guix's changes. i dropped the @see -> See change since @see is better PHPDoc.
#12
made a few small changes and committed the following to HEAD.
#13
Thanks for the update and credits :)
#14
of course! you're very welcome. thanks again for all your hard work. sorry i let it sit for so long before JaredAM prompted me to look at it.
#15
Automatically closed -- issue fixed for 2 weeks with no activity.