I'm posting an issue to get this started, and track notes on implementing the solution.

The issue is in the features/theory behind the need for this module. I created it because I always have the need to save long posts during creation, but shouldn't have to Save, THEN click Edit to get back to my form to edit again. After a first version of the module, it was obvious to me and others that it needed a feature added, which was the ability to mark the node as unpublished. This seems plain enough, on a new node that is so long you need to continually save & edit... you wouldn't want to publish it yet, even if the node type's default for that was to publish. So those features were added.

The issue here involves the built in revisions provided by Drupal....

Situation:

Creating a major revision on a node that requires the ability to save & continue editing.

Problem:

What if the user/you aren't ready to finalize or publish that new revision? You want to save a "draft" as it were of the upcoming revision, but dont want to make it live yet.

Potential Integrations:

The following are module(s) that might be used as a dependency for this type of feature:

Solution

I'm open for suggestions here. I have rarely ever used revision management in Drupal. (even though I should) I'm happy to take any suggestions on how this can integrate well with the default Drupal functionality of revisions, and how it would benefit users the most.

Comments

himerus’s picture

himerus commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +revision, +draft

Just marking this as "need more info" for now until I'm actually actively developing the features in.

himerus’s picture

himerus commented
Status: Postponed (maintainer needs more info) » Needs review
duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented

Not sure to understand this one...

Just tested the 6.x-1.2 version on my site with "Revision moderation" module - it seems to work as expected without any issues, e.g. it does send revisions into moderation for the roles that don't have "administer nodes" permission (Revision moderation module has the setting to accept revisions from "administer nodes" roles without moderation).

himerus’s picture

himerus commented

My main need for investigation here is with CORE revision management.

The issue that I see is this....
Node 1 is published and already finished.
Admin user ( or user with permission ) comes in to edit the node, AND create a new revision.
The user needs to Save & Continue editing, BUT is not ready to publish the new revision.

Currently, it would since the node is already published, either leave it published, save the new revision, and go. OR it would unpublish the already published node based on the admin settings for the module.

izmeez’s picture

izmeez commented

I just discovered this module today and it's great.

I'm still just learning Drupal and was getting ready to look at revision saving options that were discussed at Open Web Vancouver in the evening Drupal BoF (Birds of a feather) get together last week.

The module mentioned was http://drupal.org/project/revision_fu

I've just downloaded it but that's all. Now, I'm wondering which module is best to work with the save_edit module.

Any thoughts? Thanks.

Izzy

himerus’s picture

himerus commented

This is where I'm currently at with this module.
My goal is to get it finalized with ALL the features it needs, and put together a core patch for D7 as it really SHOULD be included.
It seems like it "is" working with some of the contributed revision helper modules, but it's just the one small feature mentioned above where it doesn't work with CORE revision management. Not so much that it doesn't work, as that it might not work as expected.

Any recommendations you guys find related to how it is working with the various revision helper modules would be great so that I can either recommend those module(s) or take a small part from one in order to accomplish what I need for core revision integration.

And thanks for the Kudos @izmeez, the module actually got some mention this weekend at the D4D event, and I've got a handful of nice remarks about it, so it's refreshing other than the normal "this is broken" or "that sucks" issues :D

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented

Jake,

Here are my thoughts on it, hope it helps.

The revision moderation in Drupal CORE is actually not present at all. The default Drupal install just gives the 'moderate' column in the 'node' table that is not used by the core modules currently.

The excerpt from the 'Pro Drupal Development' book:
node.moderate - Previously, a Boolean value (now it is int with default to be '0') indicating whether the node was "in moderation"; not currently used by core.
This flag shows if the whole node (not one of the revisions) is under moderation. So it only allows to mark the whole node as being moderated.

I believe that the functionality you are looking for is already implemented in the revision_moderation module (technically, don't be confused by the name). It allows to create new revisions for nodes and not make them current immediately after creation (it is controlled by the "New revision in moderation" checkbox on the Node Edit form); the whole node keeps being published and visible for all the users using the revision that is marked as current. The user then can return back to the node and continue editing the latest (not yet current) revision.
It also has the interface to manage all these new not yet current revisions and the permissions system that allows to set it up for a variety of workflows (one of which should suite you).

Probably, there is a way to integrate with this module cause it has actions to enable/disable revisions moderation on the node.

himerus’s picture

himerus commented
Status: Needs review » Closed (won't fix)

I'm changing this to "won't fix".

After some more research, and my current plan to try to get the basic features of this module into D7 core, This is not needed beyond the current functionality. What is important is that when using the auto-unpublish feature, it ONLY be available to NEW nodes. If you are saving a new revision with core modules only, it would not apply the features to auto-unpublish.

Anything like that would have to rely on contributed modules, so I'll leave it at that.

Also, be sure to chime in at http://drupal.org/node/500890 if you are interested in helping me get this into core.