FYI: og_user_roles 2.x

sun - June 3, 2009 - 23:07
Project:Organic Groups - Multiple Mandatory Groups by Role
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:active
Description

#441776: Complete rewrite into 6.x-4.x, moving all bonus features away (also for IofC, btw ;)

There is only one comment in this module in og_multiple_mandatory_groups_by_role_admin_submit():

<?php
     
//done with og_user_roles module compatibility, continue with regular roles
?>

...which I do not really understand, since nothing in the surrounding code seems to check any "special" data from og_user_roles 1.x.

In OGUR 2.x, the entire privilege escalation (i.e. granting additional user roles depending on the current group context) is handled in hook_init() already. All of the previous hacks have been removed.

As far as I can understand the code of this module, it solely seems to do its work based on regular user roles, since {users_roles} is directly queried.

I don't know whether it would make actually sense to take additionally granted roles of og_user_roles into account for this module.

Just wanted to let you know.

That said, and reading the module description once more, I actually wonder whether the functionality of this module could not be merged into og_user_roles...

#1

sun - June 3, 2009 - 23:08

Scratch that last line... This module does the opposite of OGUR, so all fine.

 
 

Drupal is a registered trademark of Dries Buytaert.