Posted by JamesAn on June 4, 2009 at 12:27am
4 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This is a child task for #422380: Convert all core module to use new static caching API focusing on the simpletest module.
Comments
#1
A wrapper function as per #422362-20: convert form.inc to use new static caching API was created to reset the static var in file_test_file_scan_callback().
#2
The last submitted patch failed testing.
#3
#4
The last submitted patch failed testing.
#5
Technically this is a duplicate of: #348455: Provide a scalable way to ensure a clean testing environment for SimpleTest, but we can just prioritize this one.
#6
Please hold off on this patch though, longer standing patch with better cleanup of loading stuff #449198: SimpleTest: Clean up test loading and related API which also adds statics stuff. (just needs committing) [perhaps you want to review]
#7
Postponed on account of #449198: SimpleTest: Clean up test loading and related API. Thanks for the heads up!
I'm not sure about reviewing that large patch... I've never reviewed anything before, much less a large patch of an unfamiliar module.. ^^"
#8
Issue has been committed.
#9
I added drupal_static() in checkPermissions(), but I am not sure where to go from there. In order to complete the process setUp() needs to take advantage of drupal_static_reset(), but I am not sure that is the scope of this particular issue.
#10
The last submitted patch failed testing.
#11
Suppose this would be a bad idea (carried over from original) :)
<?phpfunction file_test_file_scan_callback($filepath == NULL) {
?>
#12
The last submitted patch failed testing.
#13
+ return files;should be
+ return $files;#14
The last submitted patch failed testing.
#15
Test slave crapped.
#16
Rerolled.
#17
Looks good.
#18
Small code style issue:
+ } else {. Fixed that and committed to CVS HEAD.#19
Automatically closed -- issue fixed for 2 weeks with no activity.