Simply commenting out functionality that sites in production may depend on and publishing a security release afterwards is not really kind.

Attached patch fixes the introduced bug.

I'd recommend to create a new 5.x-1.5 release after committing this patch. 5.x-1.4 horribly broke one of our sites.

CommentFileSizeAuthor
views_bulk_operations.single.patch1.02 KBsun

Comments

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Reviewed & tested by the community » Needs work

Not so fast. I commented this functionality because it had problems of its own. I will not simply revert to it just like that.

Very sorry your site broke. If it's relying on a single screen, then we need to fix the bugs in the single operation mode.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

I don't see where the problem is - with the attached patch, the handling of submitted form values is identical to views using multiple operations.

Well, the issue is obvious: Without this patch, you get a fieldset above the view, containing a select, and a button that was located below the view before. Additionally, you need to confirm the (single) operation, although the operation did not need to be confirmed before. No way to get the same rendered output and behavior like with this patch. Obviously, sites in production depend on this output and form handling.

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Fixed » Needs review

I know the difference between the behaviour of single and multiple operation modes, since I wrote them both. Your patch uncomments a piece of functionality that I had commented. I'll be happy to reactivate that functionality to avoid breaking your and others' sites.

But can you please explain why you set $preserved_action_form_elements = array(); instead of $preserved_action_form_elements = $form_values;? It breaks VBO for configurable actions that rely on $form_values.

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Needs review » Fixed

I checked in a new version of the module. Please try it and let me know if it restores the broken site.

Status: Needs review » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.