Increase the maximum length of include / exclude regular expressions

deviantintegral - June 4, 2009 - 22:04
Project:External Links
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Currently, the maximum length is set to 128 characters, the default for a textfield. The attached patch increases it to 1024 characters as we were easily running into the 128 character limit with longer domains and subdomains.

AttachmentSize
increase_regex_length.patch899 bytes

#1

quicksketch - June 5, 2009 - 00:56

A very reasonable request. Would you be opposed to removing the "maxlength" property entirely? Using NULL ensures that no value is added at all.

AttachmentSize
extlink_remove_regex_maxlength.patch 1.04 KB

#2

quicksketch - July 4, 2009 - 00:11
Status:needs review» fixed

I've committed the patch from #1.

#3

System Message - July 18, 2009 - 00:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#4

BWPanda - October 23, 2009 - 01:18
Status:closed» active

I also ran into this problem, glad to find a committed patch!
Do we get a new release to go with it?

#5

quicksketch - October 23, 2009 - 04:53
Status:active» fixed

Sure, doesn't look like there have been any other issues filed in a few months, I'll make a new release tonight.

#6

BWPanda - October 23, 2009 - 05:38

Great, thanks!

#7

System Message - November 6, 2009 - 05:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.