Remove "edit-[name]-wrapper" ID from form element wrappers
quicksketch - June 5, 2009 - 04:24
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | forms system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
This patch is a continuation of #43493: FAPI: Add name/type as CSS class for form elements, which adds classes to form element wrappers. Since the form element wrapper class and ID will be essentially interchangeable (the class has slight advantages), it makes sense to remove the ID attribute entirely, since it will serve no purpose that the class does not.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| drupal_form_element_remove_wrapper_ids.patch | 5.16 KB | Idle | Failed: Invalid PHP syntax in modules/openid/openid.css. | View details | Re-test |
#1
Note that the ID attribute needs to actually be removed from the wrapper div in theme_form_element() also, so this still needs work that can be corrected once #43493: FAPI: Add name/type as CSS class for form elements is done.
#2
Awesome, subscribing
#3
#43493: FAPI: Add name/type as CSS class for form elements was committed.
#4
Re-rolled with the key lines removed from form.inc. After this patch, "edit-$id-wrapper" IDs are dead. The changes are all really straight-forward, but another set of eyes and searches are in order to make sure I didn't miss any and that I properly updated these.
#5
The last submitted patch failed testing.
#6
This patch is still ready to go.
#7
Testbot confirms.
#8
Committed to CVS HEAD. Thanks!
#9
Automatically closed -- issue fixed for 2 weeks with no activity.
#10
I think the fix for this issue introduced some regressions - see #550572: CSS+JS regressions related to form-item-[name].
-#edit-type-wrapper, #edit-severity-wrapper {+.form-item-type-wrapper, .form-item-severity-wrapper {
It seems that these should have been replaced using the following pattern instead, i.e. without the
form-itemprefix:-#edit-type-wrapper, #edit-severity-wrapper {+.type-wrapper, .severity-wrapper {