Active
Project:
UC Upsell
Version:
6.x-1.13
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
5 Jun 2009 at 06:45 UTC
Updated:
11 Jul 2011 at 19:06 UTC
Jump to comment: Most recent file
Great module!
I'm building a site on which the client wants to show the list price, sell price and an add to cart link (UC has been configured to read 'Add to bag'). Unfortunately the uc_upsell code for block content is not allowing any of these to happen.
I'll post a patch of what i've implemented for the client and then I'd like to work out a way to merge this functionality into uc_upsell. Patch follows in my next post.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 482724_200906062332+1000.patch | 2.05 KB | sammys |
| #4 | 482724_200906051839+1000.patch | 4.38 KB | sammys |
| #3 | 482724_200906051717+1000.patch | 2.24 KB | sammys |
| #2 | 482724_200906051704+1000.patch | 2.08 KB | sammys |
| #1 | 482724_200906051651+1000.patch | 1.73 KB | sammys |
Comments
Comment #1
sammys commentedPatch attached. I'm happy to discuss the module direction and adjust the patch to suit that. My client wants this functionality in the module to reduce work when updates are released.
Comment #2
sammys commentedUpdated the patch to retrieve the weights from uc_product settings.
Comment #3
sammys commentedUpdated the patch to use drupal_alter() and cleaned up the code a little. Also uncommented the add_to_cart section again.
Comment #4
sammys commentedPatched uc_upsell_cart_pane.inc as well to do things the same way.
Comment #5
torgospizzaVery, very nice! I'll see if I can work this into the next commit once I've taken a look. Thanks for taking the initiative :)
Comment #6
torgospizzaComment #7
torgospizzaSammy, I just realized you patched against 1.13. Can you re-roll both of these patches against the latest dev? Thanks!
Comment #8
sammys commentedUpdated patch to apply to DRUPAL-6--1. Nice job moving the duplicated code into the theme function! :)
Comment #9
torgospizzaThanks, I wanted to retain the changes I made in Dev (which were kind of significant) and merging patches isn't exactly something I'm good at! I'll apply this patch and try to commit a new version. Thanks!
Comment #10
torgospizzaFYI I still can't get the uc_upsell_cart_pane patch to work correctly. Does that need to be re-rolled or was that something that was included as a result of my moving code around in Dev?
Comment #11
torgospizzaReady to be committed. Will be in next Dev branch.
Slightly modified your patch to include $context rules from #488990: Call uc_price() with more context data
Comment #13
bkosborneHmm I'm using the latest release (non dev) and can't get it to display my list_price. It wasn't going thru that if-statement that list_price was in, which helps a bit - but for this particular product the list price is non-zero and exists. Why wouldn't it be enabled?
Comment #14
torgospizzaIn the Upsell settings, do you have that field enabled (checked)? It's unchecked by default.
Comment #15
bkosborneAre you talking about the "Use a "Buy Now" button instead of Add to Cart form" checkbox?
Comment #16
torgospizzaNo, under admin/store/settings/products/edit/upsell_fields you can choose which fields to show in the block. Let me know if that works for you.
Comment #17
bkosborneNow I feel dumb. Yes. I guess I've never really dealt with that area of the settings before because I always just override that info in my template anyway. Thanks for the help!
Comment #18
feconroses commentedHey there! Can i get a little help?
Im trying to display the sell price in the Cart pane but everything i have done haven't solve the problem. I tried to apply the patch manually but it didn't do anything. Tried to go to 'admin/store/settings/products/edit/upsell_fields' but it doesn't exist (it just displays the product options).
What should i do? BTW, im using the latest dev. Could anyone upload a .txt of the upsell module with the patch included?
Thank in advance!
Comment #19
torgospizzaIf you go to admin/store/settings/products/edit/fields do you get the checkboxes there for the product fields? There should be another tab called "Upsell fields" at the top that allows you to change the fields there.
This feature was added well over a year ago, and that patch was for 6.x-1.13. The 6.x-1.21 version (or Dev) should have those options available to you, no patch necessary. I'd try clearing your site cache (rebuild the Menu Router) and try again. Those options should be there... if they aren't let me know.
Comment #20
pajoh commentedTried latest build and dev version there is no admin/store/settings/products/edit/upsell_fields... or upsell option under admin/store/settings/products/edit/fields...
Comment #21
jami3z commentedSame here, have the latest dev version and these settings do not appear
Comment #22
jrivelli commentedI as well only have options for the checkboxes like normal. No checkbox options or tab for upsell.
Comment #23
haysuess commentedI was having the problem where only the List Price would display, so...I changed 'display_price' on lines 293 and 294 in up_upsell.module to 'sell_price' and it now works.
What exactly did I do? I have another working installation that works fine and it says 'display_price'. What's the deal?
Comment #24
torgospizzaI think display_price is a formatted price, whereas sell_price is directly from the node as-is, though I could be wrong.