Download & Extend
Issues

Typo in node_access_rebuild() -- db_insert('node_accesss')->db_insert('node_access')

Posted by tobiasb on June 5, 2009 at 12:12pm
Project:Drupal core
Version:7.x-dev
Component:node.module
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

See the patch

AttachmentSizeStatusTest resultOperations
drupal-node_access_rebuild.patch580 bytesIdlePassed: 11838 passes, 0 fails, 0 exceptionsView details
Login or register to post comments

Comments

#1

Posted by Dries on June 5, 2009 at 3:04pm

Welp. Should we write a test for this?

#2

Posted by tobiasb on June 5, 2009 at 5:59pm

ok, now with a small test.

AttachmentSizeStatusTest resultOperations
drupal-node_access_rebuild-482920-2.patch2.14 KBIdlePassed: 11862 passes, 0 fails, 0 exceptionsView details

#3

Posted by Dries on June 5, 2009 at 7:18pm
Status:needs review» fixed

Committed to CVS HEAD. Thanks1

#4

Posted by Dries on June 5, 2009 at 7:25pm
Status:fixed» needs review

I had to roll this patch back. Broke my environment. Need to investigate.

#5

Posted by Dave Reid on June 5, 2009 at 7:57pm
Status:needs review» needs work

There also needs to be a t() around 'Rebuild permissions' in l('Rebuild permissions', 'admin/reports/status/rebuild').

#6

Posted by Dave Reid on June 5, 2009 at 7:58pm
Status:needs work» needs review

Wierd. The commit logs show a change to a description line that was not included in the patch:
http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/node/node.module?r...

#7

Posted by JamesAn on June 5, 2009 at 8:44pm
Priority:normal» critical

Inserted the t().

We need this committed asap as all the patches are failing at the "Node Access Rebuild" test.

AttachmentSizeStatusTest resultOperations
482920-7.patch2.61 KBIdleFailed: Failed to run tests.View details

#8

Posted by System Message on June 5, 2009 at 9:00pm
Status:needs review» needs work

The last submitted patch failed testing.

#9

Posted by JamesAn on June 5, 2009 at 9:08pm
Status:needs work» needs review

Oops. Didn't realize that node.test wasn't rolled back along with node.module. This should work.

AttachmentSizeStatusTest resultOperations
482920-9.patch1.32 KBIdleFailed: 11856 passes, 4 fails, 1 exceptionView details

#10

Posted by System Message on June 5, 2009 at 9:20pm
Status:needs review» needs work

The last submitted patch failed testing.

#11

Posted by JamesAn on June 5, 2009 at 9:53pm
Status:needs work» needs review

Silly strings. The reversion wasn't exact, in that it changed the description line:
'Rebuild permissions' to 'Rebuild Permissions', which broke the rebuild permissions test as the link clicks are case sensitive.

This patch should fix it all. Phew.

AttachmentSizeStatusTest resultOperations
482920-11.patch1.32 KBIdleFailed: Failed to apply patch.View details

#12

Posted by webchick on June 5, 2009 at 9:56pm
Status:needs review» fixed

Thanks. Committed this too. Tentatively switching testing bot back on...

#13

Posted by tobiasb on June 6, 2009 at 9:43am

getInfo() must be static in E_STRICT Modus.

AttachmentSizeStatusTest resultOperations
drupal-482920-follow-up.patch976 bytesIdlePassed: 11862 passes, 0 fails, 0 exceptionsView details

#14

Posted by tobiasb on June 6, 2009 at 9:43am
Status:fixed» needs review

#15

Posted by Dries on June 6, 2009 at 10:35am
Status:needs review» fixed

Committed to CVS HEAD. Thanks.

Sorry for messing up -- I 'corrected' those link titles manually.

#16

Posted by System Message on June 20, 2009 at 10:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.