Download & Extend

Some PHP notices is shown when editing / adding vocabulary

Project:Taxonomy Node
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Module needs variable initialization and checking if array elements is set.

AttachmentSize
notice.patch1.29 KB

Comments

#1

Status:needs review» reviewed & tested by the community

Good fix.

#2

FYI I've rerolled it against the latest DRUPAL-6--1 branch.

AttachmentSize
taxonomy_node-n482944.patch 1.53 KB

#3

Status:reviewed & tested by the community» fixed

Committed, thanks.

I wonder, I know in general variable initialization is good practice, but isn't PHP high level enough to default unset variables to false when they not exist? I never saw any warning but maybe it's because I don't watch for php notices unless they are warnings or errors.

Anyway, thanks again.

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here