Module needs variable initialization and checking if array elements is set.

CommentFileSizeAuthor
#2 taxonomy_node-n482944.patch1.53 KBdamienmckenna
notice.patch1.29 KBkndr

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

Good fix.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new taxonomy_node-n482944.patch1.53 KB

FYI I've rerolled it against the latest DRUPAL-6--1 branch.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

I wonder, I know in general variable initialization is good practice, but isn't PHP high level enough to default unset variables to false when they not exist? I never saw any warning but maybe it's because I don't watch for php notices unless they are warnings or errors.

Anyway, thanks again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.