Posted by jacktonkin on June 5, 2009 at 2:30pm
9 followers
| Project: | Password Strength Disabler |
| Version: | 6.x-1.6 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
My colleagues find the strength checker confusing, but I wanted to keep the check the two passwords match. The attached patch contains the relevant code copied from modules/user/user.js in Drupal 6.12.
| Attachment | Size |
|---|---|
| disablepwstrength-check-matching.patch | 3.31 KB |
Comments
#1
I think this would need a settings page, as some would probably prefer to not display the password matching info either. Marking CNW in case some kind soul wants to come along and do this.
#2
IMO having the password match indicator is not at all confusing and I was not expecting this module to disable it!
#3
this patch generates a file called disablepwstrength.js, which has a javascript error on line 56.
The error can be fixed by adding this on line 20
var passwordStrength = $("span.password-strength", outerItem)so the surrounding lines look likevar confirmInput = $("input.password-confirm", outerItem);var confirmResult = $("span.password-confirm", outerItem);
var passwordStrength = $("span.password-strength", outerItem)
var confirmChild = $("span", confirmResult);
#4
Per #3
#5
I agree, I like the password checker but not the strength warnings.
#6
Here is a revised patch with the fix from #3
#7
And here is one that actually applies with the normal strip option
#8
#9
Damn it. 3rd time lucky.
#10
Strangly, that last patch seems to leave you with a file thats missing a closing brace. Revised patch attached.
#11
ffs. Here is one that should apply with drush make.
Any chance we can get this committed?
#12
+1
#13
+1
#14
#11 works for me. Thanks a lot !