Queue Manipulation callbacks not updated from Drupal 5
wulff - June 5, 2009 - 17:50
| Project: | Nodequeue |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
What it says on the tin :-)
Attached patch makes functions expect subqueue objects.
| Attachment | Size |
|---|---|
| nodequeue_php_notices.patch | 2.5 KB |
#1
This bug causes the sorting and removal of nodes inside a queue to fail if JS is turned off.
I am attaching an improved patch which also fixes another bug in the same functions in that it attempts to send a non-existent $node->nid variable to the nodequeue_check_token() function instead of using the $pos variable.
#2
Thanks for finding this bug and submitting a patch!
For consistency, I think we should get both the restricted and unrestricted list of nids from helper functions, rather than rewriting that query in different places. Are you able to re-roll this patch with that change? Also, it would be great if you could use the cvs diff -up options when submitting patches.
Thanks!
#3
I marked #489354: Latest Build broke Nodequeue - can't add nodes as a duplicate of this, since both depend on creating the same new nodequeue internal functions. It would be great if the fixes for both issues, and the related new helper functions were rolled into a single patch :).
#4
Seeing same issue on my site.
Cannot add nodes to nodequeues.
#5
Here's what I'm seeing.
#6
Between the reports on this issue and the other one mentioned here, I became confused about what we're actually addressing here, but now I've sorted that out.
This looks great. Thanks wulff and nrambeck for finding and fixing this. Committed.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.