Currently, the D5 version of this module puts "Never" as the first option in the list of allowed send intervals. Since "Never" is a bit of an odd special case, it seems like it would make more sense down at the bottom of the list where it will be less likely to be accidentally selected? Also, the other send intervals are arranged from more frequent to less frequent, so in that sense, "Never" should definitely be at the bottom since it is the least frequent interval possible!

Most important for my purposes, we are using this patch on our site, since it helps mitigate the effects of the bug at #483488: User and site-wide default notification send intervals can get "orphaned" :)

CommentFileSizeAuthor
notifications_reorder.patch2.28 KBDavid_Rothstein

Comments

jose reyero’s picture

jose reyero commented
Status: Needs review » Closed (won't fix)

We are just fixing critical bugs for the 5.x version, I don't think this one qualifies as such.

I'd advise to just drop the "Never" send interval. Then do some table update in your subscriptions

UPDATE notifications SET send_interval = 0 WHERE send_interval = -1;
David_Rothstein’s picture

David_Rothstein commented

We are just fixing critical bugs for the 5.x version, I don't think this one qualifies as such.

Especially since this is a feature request, not a bug report :)

The particular workaround you suggest wasn't quite going to work for Acquia's use case, although it seems good in general - I'll copy it over to the other bug report so anyone else experiencing the bug can find it more easily. In the meantime, we are OK with maintaining a patched version; the hope is we won't be on Drupal 5 much longer anyway.

Thanks!