Fivestar is breaking the theme with Journal module
mcload - June 6, 2009 - 06:56
| Project: | Journal |
| Version: | 6.x-1.2 |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
Journal box is breaking the theme. I am using the default Garland theme of Drupal. Journal boxes on the comment pages are overflowing to right side and extending the page width. Attached a capture. Also I think it would be better to decrease default box height.
| Attachment | Size |
|---|---|
| diz.png | 13.19 KB |
#1
BTW, I have this problem with Firefox 3.0.10. IE 8 does not break the theme.
#2
Based on the screenshot, this seems to be caused by Fivestar. I never had this issue, so you definitely need to fix it in your theme.
#3
How can I fix it? I am using the default Garland theme of Drupal. I did not do any changes to theme.
This is the html code of the fivestar and Journal form causing the problem:
<form action="/drupal/content/ilk-mesaj" accept-charset="UTF-8" method="post" id="fivestarextra-form-comment-49" class="fivestar-widget fivestar-combo-stars">
<div><div class="fivestar-form-vote-49 clear-block"><div class="fivestar-static-form-item"><div class="form-item">
<label>Average: </label>
<div class="fivestar-widget-static fivestar-widget-static-vote fivestar-widget-static-5 clear-block"><div class="star star-1 star-odd star-first"><span class="off">0</span></div><div class="star star-2 star-even"><span class="off"></span></div><div class="star star-3 star-odd"><span class="off"></span></div><div class="star star-4 star-even"><span class="off"></span></div><div class="star star-5 star-odd star-last"><span class="off"></span></div></div>
<div class="description"><div class="fivestar-summary fivestar-summary-average-count"><span class="empty">No votes yet</span></div></div>
</div>
</div><input type="hidden" name="content_type" id="edit-content-type-49" value="comment" />
<input type="hidden" name="content_id" id="edit-content-id-49" value="49" />
<div class="fivestar-form-item fivestar-combo-text fivestar-combo-stars fivestar-labels-hover"><div class="form-item" id="edit-vote-3-wrapper">
<label for="edit-vote-3">Your rating: </label>
<input type="hidden" name="auto_submit_path" id="edit-auto-submit-path-3" value="/drupal/fivestar/vote/comment/49/vote" class="fivestar-path" />
<input type="hidden" name="auto_submit_token" id="edit-auto-submit-token-3" value="faa1594e7b99ac6e20a14494ef0c8f77" class="fivestar-token" />
<select name="vote" class="form-select" id="edit-vote-3" ><option value="-">Select rating</option><option value="20">Poor</option><option value="40">Okay</option><option value="60">Good</option><option value="80">Great</option><option value="100">Awesome</option></select>
<div class="description"><div class="fivestar-summary fivestar-summary- fivestar-feedback-enabled"></div></div>
</div>
</div><input type="hidden" name="destination" id="edit-destination-49" value="node/1" />
<input type="submit" name="op" id="edit-fivestar-submit-49" value="Rate" class="form-submit fivestar-submit" />
<input type="hidden" name="form_build_id" id="form-a54ad475931924f9ae6bcc38c942d4ad" value="form-a54ad475931924f9ae6bcc38c942d4ad" />
<input type="hidden" name="form_token" id="edit-fivestarextra-form-comment-49-form-token" value="c340b717e909b0020aa30a45d0905e42" />
<input type="hidden" name="form_id" id="edit-fivestarextra-form-comment-49" value="fivestarextra_form_comment_49" />
<input type="hidden" name="journal_location" id="edit-journal-location-5" value="node/1" />
<div class="form-item" id="edit-journal-entry-5-wrapper">
<label for="edit-journal-entry-5">Journal entry: </label>
<textarea cols="60" rows="5" name="journal_entry" id="edit-journal-entry-5" class="form-textarea resizable"></textarea>
<div class="description">If not empty, contents of this field will be logged to the system journal.</div>
</div>
</div>
</div></form>
#4
You need to copy the array in journal_form_ids_default() into your settings.php as $conf['journal_form_ids'] and afterwards, you add the internal $form_id of that fivestar widget form to the array with a value of 0. Example:
$conf['journal_form_ids'] = array('dblog_filter_form' => 0,
...
'fivestar_form' => 0,
);
Note that 'fivestar_form' is just an example, I do not know the actual form id of Fivestar off hand.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.
#6
Forwarding this issue to Fivestar's issue queue as Journal's developer said that it seems to be caused by Fivestar. Maybe it can be fixed by Fivestar.
#7
No, I said that you have to disable Journal's form alteration for Fivestar's voting form.
#8
I tried it. However, Fivestar Extra module gives each comment a different form id created by adding the comment number to the end of "fivestarextra_form_comment_". For example, fivestarextra_form_comment_1531, fivestarextra_form_comment_85633, fivestarextra_form_comment_99725, etc. How can I disable all of them? 'fivestarextra_form_comment_' => 0 does not work. 'fivestarextra_form_comment_1531' => 0 disables only the comment #1531.