Closed (won't fix)
Project:
GMap Module
Version:
4.6.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Feb 2006 at 19:09 UTC
Updated:
6 May 2007 at 18:16 UTC
If you validate a page containing a gmap, it fails validation because ampersands in the google URL are not escaped. & needs to be represented as &. Only two lines need to be changed in the module, and a patch is included. (sorry if the patch is funky, I did try to follow guidelines.)
| Comment | File | Size | Author |
|---|---|---|---|
| gmap.module.patch | 1.29 KB | hyperlogos |
Comments
Comment #1
hyperlogos commentedAlso, on line 293 you have to add the
type="text/javascript"property, or the page still won't validate. Sorry I didn't catch this and put it into my patch... but it's pretty obvious where it does, it's in the only <script language="javascript"> statement in the module.Comment #2
webgeer commentedThis is now fixed on the 4.7 version, but I really don't have a clue what I'm doing with cvs and don't really know the best way of updating an older version. (I have a feeling it should be branched, but I don't know how that would work)
Comment #3
bdragon commented4.6 is no longer a supported Drupal version.
Comment #4
bdragon commented