Add 'forum' class wrapper around comment nodes
webchick - June 6, 2009 - 16:35
| Project: | DruBB |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Over in #483516: Remove the teaser splitter, Karen pointed out that there was a nice 'forum' wrapper that was placed around forum node forms for ease in styling. We should apply that to comment nodes as well.
#1
As an FYI, advanced_forum-comment-wrapper.tpl.php has
<div id="forum-comments"><?php print $content; ?>
<?php print $reply_link; ?>
</div>
Note that this does not run in Garland due to a bug that prevents overriding that template file.
Michelle
#2
I added the wrapper with a form prefix and suffix rather than a template file so we can always be sure it will be available no matter what template is used. We can add this back into Drubb or put it into Advanced Forum (since it sounds like you have a solution that is not always working). Just let me know if you want to make this into an AF patch instead of adding it into Drubb.
#3
Wait, are we talking about a wrapper around the view of "comments" or around the "comment" entry form? AF doesn't really do anything on the data entry end right now.
As for my solution not always working, well, that's because Garland has a bug in it. There's an issue but I don't think it's been fixed, yet.
Anything that is theme related I think makes more sense in AF, since 90% of what AF is all about is theming the forums. At least now. I do have hopes of adding a lot more features but it currently is more theming than anything.
Also, I should note that I'm going to change that template to be forum-replies. I've been changing "comments" to replies where it makes sense so that it is more agnostic with comments vs nodes.
Michelle
#4
I think this is more or less fixed though not quite through the same method.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.