The beta0 release was a nearly working release and 2.x will soon be ready to create a beta release. I want to get a 1.0 release out ASAP.

CommentFileSizeAuthor
#8 xmlsitemap-483844.patch317 KBAnonymous (not verified)
#2 xmlsitemap-483844.patch317.12 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

The attached patch will bring the code base back to beta0. We can then reapply changes (including the translations, sorry hass) as necessary to create a stable 1.0 release. I can always exclude the translations from the reset but is that what we really want?

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new xmlsitemap-483844.patch317.12 KB

What happened to the patch?!

hass’s picture

hass commented

Doesn't this not change many translatable strings? My many translation fixes have been applied between beta4 and beta5. I saw the latest code as nearly string freeze and updated many many strings. Rolling back would destroy all the work. Please - do not roll all this valuable work back...

Aside what's broken that you consider to go back to such an old release?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Hass, sorry. It's what will be best for the module. Large major changes were made without approval from the other maintainers and diverted the development of the module off from where it should be. We're not trying to de-value your translation work, but you also probably should have waited for a release candidate first. :)

hass’s picture

hass commented

RC is a good point... *damn* :-). I've done the translation to see if there are more strings to fix... mostly I find more bugs while translating and if we have a string freeze - we cannot change them anymore.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

I forgot to change the status. Are we ready for this to happen?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Hard for me to review this kind of patch. As long as it applies cleanly go ahead. Don't create a new release yet though. I need to re-commit some of the recent patches I've committed to 6.x-1.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed
StatusFileSize
new xmlsitemap-483844.patch317 KB

Just for history, attached is the cvs diff version of the patch. Dave, reopen the issues with the commits you need done and I can handle it.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Reviewed & tested by the community

It's not committed yet.

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Fixed
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

As long as it applies cleanly go ahead.

It doesn't seem to apply cleanly, if the patch removes the bug fixes, or the feature requests implementation.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.