Posted by catch on June 7, 2009 at 12:58am
5 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | comment.module |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | Quick fix |
Issue Summary
Both theme('pager') doesn't return any HTML (and the $globals are 0/1 even if there's two pages), and manually trying to go to a page doesn't work either. Haven't tracked down why yet.
Comments
#1
Marked #26966: Fix comment links when paging is used. postponed on this issue.
#2
This solves the problem.
I don't know if in the pager logic the $count_query is used, most probably not, but I don't know how to pass it. If I try to use
SelectQueryInterfaceas a chain I get a fatal error. If I try to declare it on a new line it trows an error message, but the pager works.Not very familiar with the new db api and how it should work.
#3
A proper patch. This adds the count query to the pager.
All credit to Berdir, my only merit is that I asked.
#4
A new patch that removes a change that was in the previous patch, but was not needed.
#5
It was my input, so I can't rtbc it, but the changes look good and I verified that the fix works.
#6
Works. Tests for this freshly re-rolled so we can watch them fail until this goes in #296483: TestingParty08: paged comments
#7
Committed to CVS HEAD.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.