Both theme('pager') doesn't return any HTML (and the $globals are 0/1 even if there's two pages), and manually trying to go to a page doesn't work either. Haven't tracked down why yet.

CommentFileSizeAuthor
#4 show_comments_pager.patch641 bytestic2000
#3 show_comments_pager.patch1.34 KBtic2000
#2 show_comments_pager.patch1.4 KBtic2000

Comments

catch’s picture

catch
he/him
Primary language English
commented

Marked #26966: Fix comment links when paging is used. postponed on this issue.

tic2000’s picture

tic2000 commented
Status: Active » Needs review
StatusFileSize
new show_comments_pager.patch1.4 KB

This solves the problem.
I don't know if in the pager logic the $count_query is used, most probably not, but I don't know how to pass it. If I try to use SelectQueryInterface as a chain I get a fatal error. If I try to declare it on a new line it trows an error message, but the pager works.

Not very familiar with the new db api and how it should work.

tic2000’s picture

tic2000 commented
StatusFileSize
new show_comments_pager.patch1.34 KB

A proper patch. This adds the count query to the pager.

All credit to Berdir, my only merit is that I asked.

tic2000’s picture

tic2000 commented
StatusFileSize
new show_comments_pager.patch641 bytes

A new patch that removes a change that was in the previous patch, but was not needed.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

It was my input, so I can't rtbc it, but the changes look good and I verified that the fix works.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Works. Tests for this freshly re-rolled so we can watch them fail until this goes in #296483: TestingParty08: paged comments

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.