The notify settings are not being saved in the cvs version (running Drupal 4.7 beta3). It looks to me like the $op and $edit are not being set or passed to the _notify_page($op, $edit) function.

Sorry, I'm clueless about diffs and patches, but in the head cvs its:

function notify_page() {
  include_once drupal_get_path('module', 'notify') . '/notify.inc';
  return _notify_page();
}

Whereas, it really should look like the 4.6 version:

function notify_page() {
  include_once 'modules/notify/notify.inc';

  $op = $_POST['op'];
  $edit = $_POST['edit'];

  _notify_page($op, $edit);
}

Perhaps this is a work in progress - just tell me to shut up if I'm on the wrong track...

Comments

JHeffner’s picture

JHeffner commented

I had the same issue. I was able to merge the two into 

function notify_page() {
  include_once drupal_get_path('module', 'notify') . '/notify.inc';
  $op = $_POST['op'];
  $edit = $_POST['edit'];
  return _notify_page($op, $edit);
}

and it seems to be working now from what I can tell. I'm getting notices once per hour, and the table data is being updated. I'm not so good at creating patches since I only know this fixes this one issue and not really the overall module functions.

RobRoy’s picture

RobRoy commented
Assigned: Unassigned » RobRoy
Status: Active » Fixed

Fixed in HEAD. Thanks!

RobRoy’s picture

RobRoy commented
Status: Fixed » Closed (fixed)