Posted by CorniI on June 7, 2009 at 2:33pm
Jump to:
| Project: | Version Control API -- Git backend |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | sdboyer |
| Status: | active |
| Issue tags: | git phase 2 leftovers |
Issue Summary
We need some commit hooks for vcs_git. For this we maybe need to enhance the internal API. I think for normal commits it makes most sense to use the whole API, load the whole cache file and process the commit as normal to make testing easier, and we'd need the cache file anyways as we need to update it, so I think we don't need that little performance gain which is hidden here.
Comments
#1
tagging for release...
#2
#3
Depending on the scope and difficulty of the changes, there's probably a point at which it would be worth waiting until we can generate a gitlib (analogue to svnlib) that'll make doing those operations easier. I dunno how many or how complex changes you have in mind, though, so I'm just throwing that out there as a general note.
#4
need these, BIIIIG time, for phase 2 of the migration.
well actually, we may end up implementing the hooks we want in the drupalorg module, or something less generic than vcsapi. but until that decision is made, i'm tagging this issue accordingly.
#5
#6
well, this is already in the vcs_git queue, not the vcsapi one, so i think it's quite right here ;)
The most dumbed-down version of the hooks would just fire off the log parser, so it shouldn't be that complicated.
It get's more complicated when one tries to incorporate the information given by the commit hook so that the log parser is more performant.
#7
related: #973944: Integrate GSoC 2009 Daniel Hackney work, IIRC that was one of the main goals for Daniel
#8
another related: #730738: chdir() call leads to fatal error because files can't be included anymore.
#9
#10
We're going to be writing some serverside git hooks in sprint 8 - though they'll probably end up being entirely d.o specific. Hence this issue in infra: #1012988: Create serverside git hooks that interact with our unique server environment. We need to update these before we can make a stable release, though.
#11
If you can't help Sam with this, would you please reassign it to him?
#12
We don't need this for launch, since we use our own custom set of hooks that are really quite distinct from anything that would be useful generically. Untagging, and not tagging for phase 3.
We need something in vc_git for it to be set for a stable release, I think, but that's a separate priority.
#13
removing sprint 9 tag
#14
@sdboyer: Probably related with your current work? (IIRC it would be generalizing it?)
#15
Yeah, this dovetails with generalizing the history sync mechanism and some of the new methods added to that interface. We may need to decide on what our "out of the box" target use case is for these to be really useful...maybe not. We might be able to get away with a single generic set.
#16
Not sure about the status of this, but before git hook scripts for d.o ended up managed with puppet directly they were on the drupalorg project, so pasting here a: link there.