It would be nice to use the batch API for the Fetch Now link at the admin UI. We could also think of doing this in VCS API, jpetso, marvil07, what do you think?

Comments

sdboyer’s picture

Title: Use the batch API for the Fetch Now link for git repositorys » Use the batch API for the Fetch Now link for git repositories

A big /agree from me. I thought about this quite a bit while refactoring things on the svn end to use svnlib. Although integrating it properly with the OOification is going to entail some careful thinking - probably the best way to do it will be to do a thin batch implementation in vcsapi, leaving as many of the implementation details as possible up to the backend, to be determined at runtime.

jpetso’s picture

Yeah, totally. The current method of retrieving logs is neither scalable nor user-friendly, it would be sooo cool to have it based on Batch API instead. sdboyer's comment about a thin wrapper and a backend-defined implementation are spot on. (Probably each backend would query a fixed number of commits per batch, or similar.)

If you're fine with it, I'd like this issue to be in the versioncontrol issue queue.

CorniI’s picture

Project: Version Control API -- Git backend » Version Control API
Version: » 6.x-1.0-rc1
Component: Code » API module
Priority: Minor » Normal

sure, would be cool!
The backend should just provide a func which just adds up to X commits, whole X is backend-defined and VCS Api is allowed to call it repeatedly :)

CorniI’s picture

Title: Use the batch API for the Fetch Now link for git repositories » Use the batch API for the Fetch Now link

...

marvil07’s picture

Yep, it seems like the best solution (I remember I got a timeout on my first git backend try fetching gpodder git repo this way :-D)

Let's try it after finish oo-ification? (I can't avoid smiling each time I wrote this word :-p)

marvil07’s picture

Version: 6.x-1.0-rc1 » 6.x-2.x-dev

still planned

sdboyer’s picture

Status: Active » Closed (won't fix)

not a good candidate for batching, because sync is a one-time operation.