Download & Extend
Issues

Stop relying on Apache for determining the current path

Posted by Damien Tournoud on June 7, 2009 at 6:59pm
Project:Drupal core
Version:8.x-dev
Component:base system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Apache mod_rewrite have proven to be unreliable, as it does some decoding and reencoding of the URL paths. Trying to match Apache's encoding/decoding rules with PHPs one as proven difficult, and we are still using the ugly drupal_urlencode() to double encode some characters of the path.

Let's not depend on Apache / PHP for this, and derive paths from the URL ourselves.

This patch:

- adds path-deriving logic to drupal_initialize_variables()
- removes drupal_urlencode()
- implements drupal_path_encode(), that is specialized in encoding the path part of the URL
- implements a throughout test case

Login or register to post comments

Comments

#1

Posted by Damien Tournoud on June 7, 2009 at 7:01pm
Status:active» needs review
AttachmentSizeStatusTest resultOperations
484554-stop-relying-on-apache.patch13.3 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 484554-stop-relying-on-apache.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details | Re-test

#2

Posted by System Message on June 7, 2009 at 7:10pm
Status:needs review» needs work

The last submitted patch failed testing.

#3

Posted by pwolanin on June 7, 2009 at 9:08pm

I think it might be nicer if you do something like:

+  RewriteRule ^(.*)$ index.php?applied_rewrite_rule=1 [L,QSA]

Also, I think you might want

$_SERVER['PHP_SELF']

"The filename of the currently executing script, relative to the document root." , instead of
$_SERVER['SCRIPT_NAME']

"Contains the current script's path."

#4

Posted by Damien Tournoud on June 7, 2009 at 9:16pm

I think it might be nicer if you do something like:

+ RewriteRule ^(.*)$ index.php?applied_rewrite_rule=1 [L,QSA]

I don't really see the point. It is much simpler to simple derive $_GET['q'] from the requested URI if it is not set.

Also, I think you might want
$_SERVER['PHP_SELF']

"The filename of the currently executing script, relative to the document root." , instead of
$_SERVER['SCRIPT_NAME']

"Contains the current script's path."

That was my starting point, until I saw:

// $_SERVER['SCRIPT_NAME'] can't, in contrast to $_SERVER['PHP_SELF'],
// be modified by a visitor.

The code that I use for that is simply moved from something that was already there in conf_init().

#5

Posted by Jody Lynn on September 19, 2011 at 2:40am
Status:needs work» needs review

#1: 484554-stop-relying-on-apache.patch queued for re-testing.

#6

Posted by System Message on September 19, 2011 at 2:41am
Status:needs review» needs work

The last submitted patch, 484554-stop-relying-on-apache.patch, failed testing.

#7

Posted by andypost on November 6, 2011 at 4:06am
Version:7.x-dev» 8.x-dev
Status:needs work» needs review

Related #1055856-14: Optimize settings.php discovery

AttachmentSizeStatusTest resultOperations
484554-conf.patch602 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 33,812 pass(es).View details | Re-test

#8

Posted by sun on April 23, 2012 at 2:51pm

http://www.php.net/manual/en/reserved.variables.server.php states:

'SCRIPT_FILENAME'
The absolute pathname of the currently executing script.

Note:

If a script is executed with the CLI, as a relative path, such as file.php or ../file.php, $_SERVER['SCRIPT_FILENAME'] will contain the relative path specified by the user.

'SCRIPT_NAME'
Contains the current script's path. This is useful for pages which need to point to themselves. The __FILE__ constant contains the full path and filename of the current (i.e. included) file.

---
Is this issue still relevant with these other D8 issues?

#1183208: Remove variable_get('clean_url') and switch to index.php/path pattern for dirty URL support
#1463656: Add a Drupal kernel; leverage HttpFoundation and HttpKernel

nobody click here