E_ALL warning on domain_theme_update_6200()
dlivingstone - June 8, 2009 - 06:28
| Project: | Domain Access |
| Version: | 6.x-2.0-rc7 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
I was just upgrading the entire site to D 6.12, and I noticed there was an upgrade for DA. But when I ran it, I got the following error messages:
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of db_add_primary_key(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /mysite.com/sites/all/modules/domain/domain_theme/domain_theme.install on line 45 (same error for lines 46, 47 and 48)
Thanks in advance.

#1
Gah. There is a dumb typo in domain_theme.install. I copied the function straight from the API and forgot to remove the &.
Did the update still run? Do you have the 'status' and 'filepath' columns in the {domain_theme} table?
This is an E_ALL notice and can be ignored if the update succeeded.
This could have been avoided if anyone had bothered to test the original patch.
#2
Automatically closed -- issue fixed for 2 weeks with no activity.