Add help and settings pages

leafish_paul - June 8, 2009 - 13:35
Project:Role Weights
Version:5.x-1.x-dev
Component:User interface
Category:feature request
Priority:normal
Assigned:leafish_paul
Status:closed
Description

Continuing on from #215820: Update for Drupal 6.x, we should probably add an admin help page and a settings page for the current option to sort admin forms by role (and any future settings/configuration).

Attached is the patch provided by LUTi in the previous issue. Some minor points:

  • <br> should be <br />
  • some line breaks where there shouldn't be?
  • remove the comment at the end - return system_settings_form($form) is fine

Thanks for this - it seems like a sensible thing to do and I would like to apply this to both 5.x and 6.x branches.

AttachmentSize
role_weights_admin_setting.diff3.37 KB

#1

leafish_paul - June 8, 2009 - 16:11
Version:HEAD» 6.x-1.x-dev
Status:needs work» needs review

Now includes help for Role Weights settings page (which I felt was better under "Site Configuration" to avoid any confusion as to why User Management -> Role Weights doesn't actually set role weights...) and some trimmed help text for the Help module's page.

Note: need to amend README.txt to include info on new settings page (and remove the "Advanced Settings" section).

AttachmentSize
role_weights_helpsettings_485150_2.patch 3.2 KB

#2

LUTi - June 9, 2009 - 06:45

I've applied role_weights_helpsettings_485150_2.patch - seems to work for me as expected.

#3

leafish_paul - July 7, 2009 - 14:20
Version:6.x-1.x-dev» 5.x-1.x-dev
Assigned to:Anonymous» leafish_paul
Status:needs review» patch (to be ported)

Applied to 6.x/HEAD. Needs backport.

#4

leafish_paul - July 7, 2009 - 15:14
Status:patch (to be ported)» fixed

Applied to 5.x too, holding off on 5.x-1.5 for now but this will be in the -dev snapshots.

#5

System Message - July 21, 2009 - 15:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.