(sorry for my english)

Sorry if duplicate.

views_handler_field.inc
line: "$title = t(ucwords($type));"
t() call is redundant and useless.
By the way ucwords() call too.

CommentFileSizeAuthor
#2 485296_overhead.patch1 KBdeekayen

Comments

liquixis’s picture

liquixis commented

Also:
"views_handler_field.inc" -> get_render_tokens()
line "$options = array();" is redundant and useless.
True for 2.5

deekayen’s picture

deekayen commented
Title: Unnecessary t() call » Unnecessary t() and $options initialization
Version: 6.x-2.3 » 6.x-2.6
Status: Active » Needs review
StatusFileSize
new 485296_overhead.patch1 KB

Attached patch removes the t() and the $options line. Looks like the $options code block might have been copied from options_form(), where $options is used, but in the case of get_render_tokens(), $options isn't used anywhere in the function before or after it is initialized.

liquixis’s picture

liquixis commented

deekayen, thanks for the patch

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Fixed in 2.x and 3.x branches. The ucwords() was also unnecessary, so at that point I just removed the use of $title altogether.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.