This really should get done at some point...

CommentFileSizeAuthor
#7 kiosk-[485320].patch6.14 KBtylerwalts
#3 kiosk_5_to_6.patch5.48 KBtylerwalts

Comments

tylerwalts’s picture

tylerwalts commented
Assigned: Unassigned » tylerwalts

Hello,

I've done an initial port of this to 6.x, and most of it seems to work, but still need to do some testing. Is anyone available to help test this out?

Crell, would you like me to help as a 'co-maintainer', or do you mind if I submit a 6.x-dev version?

Thanks,

- Tyler

Crell’s picture

Crell commented

Coolio!

Can you submit a patch against the 5.x-1.x branch for the D6 port? If it works I can commit that as a D6 branch and we can work from there.

tylerwalts’s picture

tylerwalts commented
StatusFileSize
new kiosk_5_to_6.patch5.48 KB

Ok, here is a patch file, attached.

tylerwalts’s picture

tylerwalts commented

ping

Have you had an opportunity to take a look at this port patch yet?

Crell’s picture

Crell commented
Status: Active » Needs work

Gah, finally looked at the patch. Sorry for the delay. :-(

It looks good from visual analysis with one exception. The "add this code to the preprocess" step is no longer necessary. Modules can implement preprocess functions in D6, so a single kiosk_preprocess() should be able to add the $kiosk variable to every template automagically with no work on the theme's part. Alternatively it could be done just in kiosk_preprocess_page(), if we wanted it to be page-level-only.

Crell’s picture

Crell commented

tylerwalts, are you still working on this? (I'd love to get this issue closed and get you onto the maintainer list.)

tylerwalts’s picture

tylerwalts commented
Status: Needs work » Needs review
StatusFileSize
new kiosk-[485320].patch6.14 KB

Hi Crell,

Yes, I made your suggested changes, which lets the user not need to do any extra steps after the initial installation, and the $kiosk is then available to themers. Sorry it took so long, got busy over the holidays and am now working on getting the CVS account set up.

Cheers,

- Tyler

tylerwalts’s picture

tylerwalts commented

The changes discussed here were committed into the CVS HEAD, then a new branch for 6.x was created, then a new tag created and added to the project page. I believe now we need someone to test out the new download on 6.x and confirm it works so that this bug can get closed.

Crell’s picture

Crell commented

Hm. I knew there was something I was forgetting to do. :-( Thanks for taking point, Tyler!

tylerwalts’s picture

tylerwalts commented
Assigned: tylerwalts » Crell

:) np. Want to test & close it?

Crell’s picture

Crell commented
Version: 5.x-1.x-dev » 6.x-1.0
Status: Needs review » Fixed

I don't actually have any D6 sites that need this functionality. :-) I'll trust you though, and file issues if needed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

banarsiamin’s picture

banarsiamin commented

hello
reales the virsion 8.0.#
and 9