I think this is highly undesirable: the path should be unique. I'll make sure validation is performed.

Comments

anarcat’s picture

anarcat commented
Priority: Critical » Normal

So there is only crude validation now, on HEAD and D5. I just committed a check against the database, but that doesn't resolve all problems, since bit-wise equal different strings may refer to the same path. In addition to the symlinks (which would require backend validation), we could sanitize paths a bit like what is done here:

http://ca.php.net/manual/fr/function.realpath.php#84012

anarcat’s picture

anarcat commented
Status: Active » Closed (fixed)

i think that with the tolower() razzia that was done by omega8, we can close this.

omega8cc’s picture

omega8cc commented

Yes, it is fixed, so you can't use the same path or the same name for the platform (even with different case), see:

https://skitch.com/omega8cc/r4nue/create-platform-aegir-hosting-system-b...
https://skitch.com/omega8cc/r4nui/create-platform-aegir-hosting-system-b...

However it was fixed by mig5: #1039010: Enforce that platform names and paths must be unique, even across remote servers, because of the spoke model