How to reproduce:

  1. Create a flat-rate "free shipping" (i.e. $0) quote method.
  2. Add items to cart, go to checkout
  3. Select the Free Shipping option as your shipping choice.
  4. Enter an invalid credit card date.
  5. Problem arises: shipping quotes not shown (have to click "click to calculate" again), shipping selection not remembered, shipping line item not shown.

I imagine that somewhere the 0 cost is being equivocated as false and so not registering as the selected option. I'll try to poke around and see if I can find out where this might be happening, but at this point I'm not sure even where to begin. Any help appreciated!

CommentFileSizeAuthor
#1 485438-uc_quote_free_shipping.patch646 bytesjrust

Comments

jrust’s picture

jrust commented
Status: Active » Needs review
StatusFileSize
new 485438-uc_quote_free_shipping.patch646 bytes

Got it! Not as buried as I thought. Changed it from checking for an empty value in 'rate' to checking if 'rate' isset.

rszrama’s picture

rszrama commented
Issue tags: +ubercamp sprint
Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

Once I made sure I was patching the right branch, everything worked out right. I think it's worth noting that if you had more than one shipping quote and you trigger this bug, the shipping quotes are still displayed, but the first one is selected and not the free one. The patch also fixes this behavior.

Thanks, and committed.

Status: Fixed » Closed (fixed)
Issue tags: -ubercamp sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +ubercamp sprint

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.