Posted by mlncn on June 8, 2009 at 7:23pm
| Project: | Bot |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
We would love to be able to search the bot logs along with the rest of Drupal content-- maybe as a separate tab on the /search page would be a much easier implementation though.
Comments
#1
We would like this feature too. I think this is *the* reason we'd want to use the drupal bot instead of one of the many others.
#2
Anyone have a copy of Pro Drupal Development handy and want a good learning Drupal exercise? PDD has a chapter on doing something very similar!
#3
Here is a patch, includes some CSS and form structure changes to the filter form on the bot_log interface. The filter adds two more elements to the url: a keyword identifying the table field that is used, and the search term which is then used in the query as LIKE "%keyword%". The keywords persist on paging between days.
Also cleaned up the filter form a little bit, removed the wrapping div, instead packed the date filter and the search into its own fieldset, inline display is applied from CSS. Margins had to be redone as well, but I think it looks quite nice with this change.
#4
i've tested the patch by snufkin at #3 - it does as s/he describes, but doesn't do the original feature request, which is to include the irc logs in the indexed content for drupal searches.
#5
simple patch that adds searching of the logs.
uses SQL and LIKE '%keyword%'; --- won't scale without some indexes and such what.
#6
A search that just searches within one day isn't that useful; I could do that with my browser search. Whether or not it uses drupal's index, a universal search i needed, I think...
#7
Re-rolled patch from #5. The first [unrelated] change in the patch was removed, as it has since been fixed. Otherwise no changes.
dafeder: looks like you were trying the patch from #3?
This implementation is simple and won't scale well, as Shiny suggests, but it searches logs over all time.