Not utilizing new price handler functionality on attribute level

I've tested the patch. I also upgraded ubercart and uc_vat to the latest .dev versions - but with uc_vat enabled it still doesn't work.

this is what I try:
on the product node page I have a select box to choose between two options of an attribute. the default option adds 0.- to the price the other 200.-
with uc_vat disabled the price changes instantly when changing the attribute options.

then I enable uc_vat. reload the product node page. and try again (without cron for testing purpose)
same as above it works - BUT the prices are still displayed without VAT.

then I run cron. and reload the product node page.
now the price is displayed with VAT. but when I change from the default option to the other the price doesn't update anymore.

as a further test I disabled the price value caching - but that didn't help either. still didn't work.

I put status on needs work - but I'm actually not sure if the work is needed in this module.

one more thing:
shouldn't the option prices also go through the price handler functionality? (see lines 257, 259 & 260)

this might help... the price is actually correctly updated up to line 278 (all line numbers referring to .dev build 7.5.09):

$output['updated_price'] = uc_currency_format($updated_price);

but somehow this 'updated_price' get's directly or indirectly replaced before reaching the screen.

Hi Antoine,

I was referring to the .dev version as in CVS (because on my system I have your patch and the patch from andreiashu). that's why I have pasted the code to avoid misunderstanding.. but I guess that was unavoidable ;).

as it's kind of the last line of this module's code I don't think that "un-applying" andreiashu's patch will change anything (but I'm happy to do the test if you think otherwise). I believe the value leaves this module correctly but doesn't reach the display later in the process. but I haven't yet been able to understand if something else overwrites it - or if with uc_vat installed a different variable gets displayed altogether.

one more thing:
shouldn't the option prices also go through the price handler functionality? looking at post #6 these must be lines 275, 277 & 278 in your version.

@cYu: I have tested the patch (post #8) and it is good. I recommend this patch to be applied to the .dev version.

there is still work to be done to be 100% VAT compatible. but I completely agree that this is better done in a new issue - and when I understand this correctly the issue actually needs to be opened with ubercart core. once we have it fixed there we can open a new issue for uc_aac (if needed).

after my post #10 I found #475474: Price alterer contexts and VAT support. for the current implementation of uc_price() the patch provided by AntoineSolutions would still be a big step forward (I use it with uc_vat). but the chances are high that it will need a big rewrite.

so up to you if you want to apply it as baseline or if you prefer to wait.

updated to be against new dev branch. disregard previous patches, they are for the old branch 6.x-1.x.

I had to add:

'type' => 'product',

to the attribute context to get it to work with uc_vat.

I'm not sure what the correct type to use is. I was now looking a while for the context respectively type "handbook" but couldn't find it. for that reason I don't change status - but for me it actually works after the change.

your latest patch doesn't work.

it works when we use:

          'subject' => array(
            'node' => node_load($nid),
          ),

instead of:

          'subject' => array(
            'node' => $product,
          ),

as $product is not defined in uc_aac_form_alter().

your latest patch is working.

good team work :).

cheers