When I create a kit that morphs over time (adding new items, removing old items, changing the prices of items also present in the kit), I need to re-edit the kit each time to fix the price and not only that, I need to compute the correct total too because you only show the "current total" with the adjustments I already made. Two or three items, not too bad, 5+... wow! Loads of math here. 8-)

I have no clue how your system works, what I'd like is a way to enter 90% in the total price which would mean 90% of the total price, whatever the total currently is.

Thank you.
Alexis Wilke

Comments

rszrama’s picture

rszrama commented
Status: Active » Postponed
tr’s picture

tr commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Postponed » Active

Reasonable request, I don't know why it was postponed. uc_product_kit is already converting the kit price to a percentage discount internally, then doing all calculations with that percentage. So letting the user specify the percentage should be an easy change.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This would also solve #828576: Product Kit Price and Discount Administration Overhead, closing that one as a duplicate.

tr’s picture

tr commented
Component: Code » Product kits

Moving to "Product kit" component.

Anyone want to try their hand at writing a patch for this?

bancarddata’s picture

bancarddata commented

Subscribing - I'd like to be able to use percentages in attribute options as well, if this is not also addressing that. I typically have parts that are set to the default option's price as a base, with other options being +/- that price. But I usually have a "None required" option as well, which would be nice to default to "-100%", so any price changes will always have that option equaling $0.

AlexisWilke’s picture

AlexisWilke commented

bancarddata,

I think you should create a separate issue for such a feature as it would be affect code in a completely different area.

Thank you.
Alexis

millenniumtree’s picture

millenniumtree
he/him/they/them
Location Volcano, HI
commented

Comment moved to issue referenced in #8 below.

tr’s picture

tr commented

@millenniumtree: The topic of this issue is a feature request to support pricing discounts expressed as a percent rather than a monetary value. Any other problems with Product kits should be raised in a new issue.

I did find a small bug that was recently introduced into the Product kit module by commit 1fa876fc that makes it so you can't enter a blank value in the "Total price" field, thus preventing this form from working properly if total price isn't entered. I have opened a new issue for that problem: #1385950: uc_price doesn't work for Product kit total price field. A quick fix is to revert that commit, or you can track and contribute to that new issue to help with a proper fix. Any further discussion of this problem should be in that new issue.

The rest of your post seems to be a feature request to change the way this pricing form works. Please open a new issue if you want to pursue that. The best way to get a change like that into Ubercart is to provide a patch - that way your suggestion can be reviewed and tested by the community before being put in.

millenniumtree’s picture

millenniumtree
he/him/they/them
Location Volcano, HI
commented

Good to know.
I'll post on the new topic then, thanks!

digital fire’s picture

digital fire commented

Was this issue ever resolved? I seem to be having an issue with the product kit discounts and I'm thinking it may be related to this. I will include more details once i know if this issue is unresolved.

tr’s picture

tr commented
Version: 7.x-3.x-dev » 8.x-4.x-dev
Issue summary: View changes

New features need to go into 8.x-4.x first at this point, then get backported as needed.